From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30B7C25B0C for ; Mon, 8 Aug 2022 06:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235433AbiHHGQo (ORCPT ); Mon, 8 Aug 2022 02:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233697AbiHHGQn (ORCPT ); Mon, 8 Aug 2022 02:16:43 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB0B63CA for ; Sun, 7 Aug 2022 23:16:41 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id x25so8757357ljm.5 for ; Sun, 07 Aug 2022 23:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=fciYAWSZMoQdWO6XEfsJh4SM4ZwutMpTVspkx/ExHXE=; b=bk4Hper+0UryWZ+lPbB2cSDixGFoOcgSbcXAFwqlIywgvpLQ98GuypeYJ3VBpj2xfy j7nEM0054ptCZ+KFUBB3GtBXRPKadXLk9wfpboDt1ZqwxcSUqKEdjK4zjGIiP8tZZZjE U1uhlDjUnqiYX7ei/0WFkfaSTDzlmz6mFjnTUFZsUJLn0x4eCwuH9iogaQTgBL5hqpIn lSQZZSch7OFAXDKMoobdNkGJqFgFiUAhE1VVW0amRv09HDQOHzDEcNCG1izdtY76rjJk Ieet4gIcOBL9cEhVL2uMzMl9YEjpA5O4JLAJkqc42qV12FrdGle2xXQquZHu4Y8CevGi Qv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=fciYAWSZMoQdWO6XEfsJh4SM4ZwutMpTVspkx/ExHXE=; b=LaFxPy/oPy1YC3vrRxfb2EBo7uowD0Z9cGbIcucFImjc4J67wA0fbgOxxQwSkDea6j yLC8E2Wj1CEaHR9+kgyE6edVCSdw7BOhPwxpwbF63BPAGzcvwQ+ZOHjVWaBTS1ng0oKV QfIHed/nuR1GzlWlG8t7Jq3iKqBGBRM5UrCy9bep37zYA9ASGOfCwWiH6yL/CaGmc/V6 4TgP0hRqJzio+H6Vp6fqGxK+zZ+QgniSn5RJfJPrKXCa88pwyTJ57VJ+5jToKjkcCphk /aCjJHcJJHAxfOHKuYSIG78V4MHty8gvrkpfwpOblrdJhdLxbfNrQBrVKk+98bdqwhg5 zzfA== X-Gm-Message-State: ACgBeo2Xz1/DeBZt2DoPYSoVCwPDhjQbpmf5bTGCO/+cJOSGSyizLaQf seArqoHFYbNpyje7tC+p7kgfMg== X-Google-Smtp-Source: AA6agR5vMHc+EuCiaOqe/h+2rKNhnqSu9yo7e+ImS+1K4uYlMyJij6BbOz3rr/MMTTXBK9Isto4CpQ== X-Received: by 2002:a2e:beaa:0:b0:25e:34d0:4d57 with SMTP id a42-20020a2ebeaa000000b0025e34d04d57mr5361387ljr.329.1659939399654; Sun, 07 Aug 2022 23:16:39 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id x9-20020a056512078900b0048a891e4d88sm1310468lfr.193.2022.08.07.23.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Aug 2022 23:16:39 -0700 (PDT) Message-ID: Date: Mon, 8 Aug 2022 09:16:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 4/6] dt-bindings: clk: meson: add S4 SoC peripheral clock controller bindings Content-Language: en-US To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-5-yu.tu@amlogic.com> <562043e1-83d4-d4ab-2c18-20b770b02955@linaro.org> <4d923b9e-61d4-b4cc-906f-cb186a16e1f4@amlogic.com> From: Krzysztof Kozlowski In-Reply-To: <4d923b9e-61d4-b4cc-906f-cb186a16e1f4@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2022 11:33, Yu Tu wrote: > Hi Krzysztof, > Thank you for your reply. > > On 2022/8/5 17:15, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 05/08/2022 10:57, Yu Tu wrote: >>> Add peripheral clock controller compatible and dt-bindings header for >>> the of the S4 SoC. >>> >>> Signed-off-by: Yu Tu >>> --- >>> .../bindings/clock/amlogic,s4-clkc.yaml | 92 ++++++++++++ >>> include/dt-bindings/clock/amlogic,s4-clkc.h | 131 ++++++++++++++++++ >>> 2 files changed, 223 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml >>> create mode 100644 include/dt-bindings/clock/amlogic,s4-clkc.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml >>> new file mode 100644 >>> index 000000000000..2471276afda9 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/amlogic,s4-clkc.yaml >> >> Filename should be based on compatible, so amlogic,s4-periphs-clkc.yaml > I will correct as you suggest in the next version. >> >>> @@ -0,0 +1,92 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/amlogic,s4-clkc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Amlogic Meson S serials Peripheral Clock Controller Device Tree Bindings >> >> s/Device Tree Bindings// > what's mean? It's a expression (simplified not accurate) from many Linux tools, e.g. sed, vim etc s/SEARCH/REPLACE/ so just drop that piece I wrote above. Best regards, Krzysztof