From: David Laight <David.Laight@ACULAB.COM>
To: 'Luo bin' <luobin9@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"luoxianjun@huawei.com" <luoxianjun@huawei.com>,
"yin.yinshi@huawei.com" <yin.yinshi@huawei.com>,
"cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>,
"chiqijun@huawei.com" <chiqijun@huawei.com>
Subject: RE: [PATCH net-next v1] hinic: fix strncpy output truncated compile warnings
Date: Fri, 7 Aug 2020 09:32:07 +0000 [thread overview]
Message-ID: <e7a4fcf12a4e4d179e2fae8ffb44f992@AcuMS.aculab.com> (raw)
In-Reply-To: <20200807020914.3123-1-luobin9@huawei.com>
From: Luo bin
> Sent: 07 August 2020 03:09
>
> fix the compile warnings of 'strncpy' output truncated before
> terminating nul copying N bytes from a string of the same length
>
> Signed-off-by: Luo bin <luobin9@huawei.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> V0~V1:
> - use the strlen()+1 pattern consistently
>
> drivers/net/ethernet/huawei/hinic/hinic_devlink.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> index c6adc776f3c8..1ec88ebf81d6 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> @@ -342,9 +342,9 @@ static int chip_fault_show(struct devlink_fmsg *fmsg,
>
> level = event->event.chip.err_level;
> if (level < FAULT_LEVEL_MAX)
> - strncpy(level_str, fault_level[level], strlen(fault_level[level]));
> + strncpy(level_str, fault_level[level], strlen(fault_level[level]) + 1);
Have you even considered what that code is actually doing?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-08-07 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 2:09 [PATCH net-next v1] hinic: fix strncpy output truncated compile warnings Luo bin
2020-08-07 9:32 ` David Laight [this message]
2020-08-08 3:36 ` luobin (L)
2020-08-08 3:42 ` David Miller
2020-08-08 6:44 ` Kees Cook
2020-08-09 3:19 ` luobin (L)
2020-08-10 8:15 ` David Laight
2020-08-09 2:59 ` luobin (L)
2020-08-08 12:50 ` David Laight
2020-08-09 3:35 ` luobin (L)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a4fcf12a4e4d179e2fae8ffb44f992@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luobin9@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).