From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Theodore Ts'o" <tytso@mit.edu>, linux-mips@linux-mips.org
Cc: "Andrea Gelmini" <andrea.gelmini@gelma.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Leonid Yegoshin" <Leonid.Yegoshin@imgtec.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Matt Redfearn" <matt.redfearn@imgtec.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Ralf Bächle" <ralf@linux-mips.org>,
"Zubair Lutfullah Kakakhel" <Zubair.Kakakhel@imgtec.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()
Date: Mon, 24 Oct 2016 16:02:49 +0200 [thread overview]
Message-ID: <e7ac4cba-bce1-edf5-a537-4c06a357bfb3@users.sourceforge.net> (raw)
In-Reply-To: <20161024131311.ttwr2bblphg6vd2b@thunk.org>
>> A string which did not contain a data format specification should be put
>> into a sequence.
>
> This is not a correct description of what you are doing. A better
> description would be to say:
>
> "Use seq_put[sc]() instead of seq_printf() since the string does not
> contain a data format specifier".
Thanks for your suggestion about an other wording.
> You should fix this in all the patches.
I am curious if a second approach will become acceptable in the near future.
> Please also note this is really pointless patch,
If you do not like the proposed changes for some subsystems so far,
I would appreciate another clarification:
* Could you tolerate them for any other software components?
* May I continue to inform involved developers about similar change possibilities?
> since reading from /proc isn't done in a tight loop, and even if it were,
> the use of vsprintf is the tiniest part of the overhead.
Thanks for your software development opinion.
> It otherwise reduces the text space or the number of lines of code....
Do other system testers and Linux users care a bit more for corresponding
chances in improved software efficiency?
Regards,
Markus
next prev parent reply other threads:[~2016-10-24 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 12:26 [PATCH 0/4] MIPS-kernel: Fine-tuning for two function implementations SF Markus Elfring
2016-10-24 12:27 ` [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show() SF Markus Elfring
2016-10-24 13:13 ` Theodore Ts'o
2016-10-24 14:02 ` SF Markus Elfring [this message]
2016-10-24 14:20 ` Theodore Ts'o
2016-10-24 14:53 ` SF Markus Elfring
2016-10-24 15:51 ` Theodore Ts'o
2016-10-24 18:10 ` Further software improvements around Linux sequence API? SF Markus Elfring
2016-10-24 12:28 ` [PATCH 2/4] MIPS/kernel/proc: Use seq_putc() in show_cpuinfo() SF Markus Elfring
2016-10-24 12:29 ` [PATCH 3/4] MIPS/kernel/proc: Replace 28 seq_printf() calls by seq_puts() " SF Markus Elfring
2016-10-24 12:30 ` [PATCH 4/4] MIPS/kernel/proc: Combine four seq_printf() calls into one call " SF Markus Elfring
2016-10-25 8:55 ` Geert Uytterhoeven
2016-10-25 9:08 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ac4cba-bce1-edf5-a537-4c06a357bfb3@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.gelmini@gelma.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=paul.gortmaker@windriver.com \
--cc=ralf@linux-mips.org \
--cc=tytso@mit.edu \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).