linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saravanan Sekar <saravanan@linumiz.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux@roeck-us.net, linux-kernel@vger.kernel.org,
	marten.lindahl@axis.com, jdelvare@suse.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC
Date: Thu, 1 Dec 2022 12:29:44 +0100	[thread overview]
Message-ID: <e7b20055-4f44-aa91-e18d-9fb0f835fbf1@linumiz.com> (raw)
In-Reply-To: <bc86121f-3cc2-1e55-4c6a-02cb1644a8bd@linaro.org>

On 01/12/22 11:26, Krzysztof Kozlowski wrote:
> On 01/12/2022 05:46, Saravanan Sekar wrote:
>> Document mpq7932 power-management IC
>>
>> Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>
>> ---
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
Hi Krzysztof,

Thanks for your time to review and feedback.

Here are the summary of comments on V1, I have fixed all according to my 
understanding.


1. Use subject prefixes matching the subsystem (git log --oneline -- ...).

git log --oneline -- Documentation/devicetree/bindings/hwmon/pmbus/
1ccca53618c4 dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC
373c0a77934c dt-bindings: hwmon/pmbus: Add ti,lm25066 power-management IC
7f464532b05d dt-bindings: Add missing 'additionalProperties: false'
8a36e38d8b0f dt-bindings: hwmon/pmbus: Add ti,ucd90320 power sequencer

I have used the same format of 373c0a77934c.

2. Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

I did run dt_binding_check on V1 but failed to notice warnings. Fixed 
warning on V2 and didn't observed any warnings.

3. Why requiring nodename? Device schemas usually don't do that.
dropped "pattern: "pmic@[0-9a-f]{1,2}""

4. regulators node is a regulator with one more regulator? Drop.
dropped "$ref: regulator.yaml# "

5. Messed indentation. Use same for entire example, e.g. 4-spaces.
Fixed it.


Please help if anything which I missed


> Thank you.
> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2022-12-01 11:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  4:46 [PATCH v2 0/4] Add support for mpq7932 PMIC IC Saravanan Sekar
2022-12-01  4:46 ` [PATCH v2 1/4] hwmon: pm_bus: core: Add min_uV in pmbus regulator helper macro Saravanan Sekar
2022-12-01  4:46 ` [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC Saravanan Sekar
2022-12-01 10:26   ` Krzysztof Kozlowski
2022-12-01 11:29     ` Saravanan Sekar [this message]
2022-12-01 11:38       ` Krzysztof Kozlowski
2022-12-01 15:37         ` Guenter Roeck
2022-12-01 15:57           ` Saravanan Sekar
2022-12-01 16:15           ` Krzysztof Kozlowski
2022-12-01 16:38             ` Saravanan Sekar
2022-12-01 16:43               ` Krzysztof Kozlowski
2022-12-01 16:52                 ` Saravanan Sekar
2022-12-01 17:00                   ` Krzysztof Kozlowski
2022-12-01 13:36   ` Rob Herring
2022-12-01 16:16   ` Krzysztof Kozlowski
2022-12-01  4:46 ` [PATCH v2 3/4] hwmon: (pmbus/mpq7932) Add a support for mpq7932 Power Management IC Saravanan Sekar
2022-12-01 10:26   ` Krzysztof Kozlowski
2022-12-01 11:36     ` Saravanan Sekar
2022-12-01 15:34   ` Guenter Roeck
2022-12-07  3:51     ` Saravanan Sekar
2022-12-07  4:46       ` Guenter Roeck
2022-12-01  4:46 ` [PATCH v2 4/4] MAINTAINERS: Update the entry for MPQ7932 PMIC driver Saravanan Sekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7b20055-4f44-aa91-e18d-9fb0f835fbf1@linumiz.com \
    --to=saravanan@linumiz.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marten.lindahl@axis.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).