From: Mike Kravetz <mike.kravetz@oracle.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()
Date: Tue, 2 Mar 2021 13:54:22 -0800 [thread overview]
Message-ID: <e7b7532a-6087-7307-1f89-f7db26004bae@oracle.com> (raw)
In-Reply-To: <20210301104726.45159-1-linmiaohe@huawei.com>
On 3/1/21 2:47 AM, Miaohe Lin wrote:
> vma_resv_map(vma) checks if a reserve map is associated with the vma. The
> routine vma_needs_reservation() will check vma_resv_map(vma) and return 1
> if no reserv map is present. map_chg is set to the return value of
> vma_needs_reservation(). Therefore, !vma_resv_map(vma) is redundant in the
> expression:
> map_chg || avoid_reserve || !vma_resv_map(vma);
> Remove the redundant check.
>
> [Thanks Mike Kravetz for reshaping this commit message!]
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 60c67eb016f7..060005b868cf 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2314,7 +2314,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,
>
> /* If this allocation is not consuming a reservation, charge it now.
> */
> - deferred_reserve = map_chg || avoid_reserve || !vma_resv_map(vma);
> + deferred_reserve = map_chg || avoid_reserve;
> if (deferred_reserve) {
> ret = hugetlb_cgroup_charge_cgroup_rsvd(
> idx, pages_per_huge_page(h), &h_cg);
>
prev parent reply other threads:[~2021-03-02 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 10:47 [PATCH v2] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page() Miaohe Lin
2021-03-02 21:54 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b7532a-6087-7307-1f89-f7db26004bae@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).