From: Waiman Long <longman@redhat.com>
To: Abhishek Bhardwaj <abhishekbh@google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Anthony Steinhauser <asteinhauser@google.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Jim Mattson <jmattson@google.com>,
Joerg Roedel <joro@8bytes.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode
Date: Thu, 2 Jul 2020 20:17:57 -0400 [thread overview]
Message-ID: <e7bc00fc-fe53-800e-8439-f1fbdca5dd26@redhat.com> (raw)
In-Reply-To: <20200702221237.2517080-1-abhishekbh@google.com>
On 7/2/20 6:12 PM, Abhishek Bhardwaj wrote:
> This change adds a new kernel configuration that sets the l1d cache
> flush setting at compile time rather than at run time.
>
> Signed-off-by: Abhishek Bhardwaj <abhishekbh@google.com>
Can you explain in the commit log why you need a compile time option
whereas the desired mitigation can also be set via a boot command line
option?
The code looks OK, but the question I have is why.
Cheers,
Longman
next prev parent reply other threads:[~2020-07-03 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 22:12 [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode Abhishek Bhardwaj
2020-07-02 23:16 ` Randy Dunlap
2020-07-03 0:17 ` Waiman Long [this message]
2020-07-03 3:17 ` Anthony Steinhauser
2020-07-03 6:43 ` Abhishek Bhardwaj
2020-07-03 11:40 ` Mike Rapoport
2020-07-03 14:00 ` Doug Anderson
2020-07-05 15:23 ` Mike Rapoport
2020-07-05 15:56 ` Waiman Long
2020-07-05 18:22 ` Abhishek Bhardwaj
2020-07-05 18:48 ` Waiman Long
2020-07-05 21:51 ` Abhishek Bhardwaj
[not found] ` <f8e84764-1cc7-c4e5-4e4f-4b907204a374@redhat.com>
2020-07-08 19:32 ` Abhishek Bhardwaj
2020-07-05 17:33 ` Doug Anderson
2020-07-03 14:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7bc00fc-fe53-800e-8439-f1fbdca5dd26@redhat.com \
--to=longman@redhat.com \
--cc=abhishekbh@google.com \
--cc=asteinhauser@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=jpoimboe@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@linux.ibm.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).