From: Jeff Layton <jlayton@kernel.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file
Date: Tue, 19 Oct 2021 11:46:51 -0400 [thread overview]
Message-ID: <e7bdcf0b279989e51c2c333e89acf3e1d476eff0.camel@kernel.org> (raw)
In-Reply-To: <20211019141427.GA15063@fieldses.org>
On Tue, 2021-10-19 at 10:14 -0400, J. Bruce Fields wrote:
> On Tue, Oct 19, 2021 at 06:50:21AM -0400, Jeff Layton wrote:
> > On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> > > The mandatory file locking got removed due to its problems, but
> > > there's still a comment inside fs/locks.c pointing to the removed
> > > doc.
> > >
> > > Remove it.
> > >
> > > Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > >
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/
> > >
> > > fs/locks.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/fs/locks.c b/fs/locks.c
> > > index d397394633be..94feadcdab4e 100644
> > > --- a/fs/locks.c
> > > +++ b/fs/locks.c
> > > @@ -61,7 +61,6 @@
> > > *
> > > * Initial implementation of mandatory locks. SunOS turned out to be
> > > * a rotten model, so I implemented the "obvious" semantics.
> > > - * See 'Documentation/filesystems/mandatory-locking.rst' for details.
> > > * Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> > > *
> > > * Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> >
> > Thanks Mauro. I'll pick this into my locks branch, so it should make
> > v5.16 as well.
>
> Could we delete the rest too?
>
> We don't do those changelog-style comments any more; they're in the git
> history if you need them. I can sort of get leaving some in out of
> respect or if they've still provide some useful information. But
> keeping comments referring to code that doesn't even exist any more just
> seems confusing.
>
> --b.
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 3d6fb4ae847b..2540b7aedeac 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -59,17 +59,6 @@
> * once we've checked for blocking and deadlocking.
> * Andy Walker (andy@lysaker.kvaerner.no), April 03, 1996.
> *
> - * Initial implementation of mandatory locks. SunOS turned out to be
> - * a rotten model, so I implemented the "obvious" semantics.
> - * See 'Documentation/filesystems/mandatory-locking.rst' for details.
> - * Andy Walker (andy@lysaker.kvaerner.no), April 06, 1996.
> - *
> - * Don't allow mandatory locks on mmap()'ed files. Added simple functions to
> - * check if a file has mandatory locks, used by mmap(), open() and creat() to
> - * see if system call should be rejected. Ref. HP-UX/SunOS/Solaris Reference
> - * Manual, Section 2.
> - * Andy Walker (andy@lysaker.kvaerner.no), April 09, 1996.
> - *
> * Tidied up block list handling. Added '/proc/locks' interface.
> * Andy Walker (andy@lysaker.kvaerner.no), April 24, 1996.
> *
> @@ -95,10 +84,6 @@
> * Made the block list a circular list to minimise searching in the list.
> * Andy Walker (andy@lysaker.kvaerner.no), Sep 25, 1996.
> *
> - * Made mandatory locking a mount option. Default is not to allow mandatory
> - * locking.
> - * Andy Walker (andy@lysaker.kvaerner.no), Oct 04, 1996.
> - *
> * Some adaptations for NFS support.
> * Olaf Kirch (okir@monad.swb.de), Dec 1996,
> *
IDK...Do we want to "erase history" selectively like that?
Maybe we should just get rid of the whole pile of "changelog" comments
in fs/locks.c? They aren't terribly useful these days anyhow.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2021-10-19 15:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 8:03 [PATCH v3 00/23] Fix some issues at documentation Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 01/23] visorbus: fix a copyright symbol that was bad encoded Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 02/23] libbpf: update index.rst reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 03/23] docs: accounting: update delay-accounting.rst reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference Mauro Carvalho Chehab
2021-10-24 22:08 ` Linus Walleij
2021-10-25 12:32 ` Rob Herring
2021-10-19 8:04 ` [PATCH v3 05/23] MAINTAINERS: update aspeed,i2c.yaml reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 06/23] MAINTAINERS: update faraday,ftrtc010.yaml reference Mauro Carvalho Chehab
2021-10-24 21:53 ` Linus Walleij
2021-10-19 8:04 ` [PATCH v3 07/23] MAINTAINERS: update ti,sci.yaml reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 08/23] MAINTAINERS: update intel,ixp46x-rng.yaml reference Mauro Carvalho Chehab
2021-10-24 21:52 ` Linus Walleij
2021-10-19 8:04 ` [PATCH v3 09/23] MAINTAINERS: update nxp,imx8-jpeg.yaml reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 10/23] MAINTAINERS: update gemini.yaml reference Mauro Carvalho Chehab
2021-10-24 21:52 ` Linus Walleij
2021-10-19 8:04 ` [PATCH v3 11/23] MAINTAINERS: update brcm,unimac-mdio.yaml reference Mauro Carvalho Chehab
2021-10-19 16:08 ` Florian Fainelli
2021-10-19 8:04 ` [PATCH v3 12/23] MAINTAINERS: update mtd-physmap.yaml reference Mauro Carvalho Chehab
2021-10-24 21:53 ` Linus Walleij
2021-10-19 8:04 ` [PATCH v3 13/23] Documentation: update vcpu-requests.rst reference Mauro Carvalho Chehab
2021-10-19 9:22 ` Anup Patel
2021-10-19 8:04 ` [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference Mauro Carvalho Chehab
2021-10-19 9:35 ` Quentin Monnet
2021-10-19 22:31 ` Alexei Starovoitov
2021-10-20 5:46 ` Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 15/23] docs: translations: zn_CN: irq-affinity.rst: add a missing extension Mauro Carvalho Chehab
2021-10-19 21:20 ` Jonathan Corbet
2021-10-19 8:04 ` [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo Mauro Carvalho Chehab
2021-10-19 21:21 ` Jonathan Corbet
[not found] ` <f0269915-4863-9ed6-dedd-592f2e308f46@redhat.com>
2021-11-01 7:46 ` Alex Shi
2021-11-01 13:38 ` teng sterling
2021-11-01 13:59 ` David Hildenbrand
2021-10-19 8:04 ` [PATCH v3 17/23] docs: fs: locks.rst: update comment about mandatory file locking Mauro Carvalho Chehab
2021-10-19 10:47 ` Jeff Layton
2021-10-19 8:04 ` [PATCH v3 18/23] fs: remove a comment pointing to the removed mandatory-locking file Mauro Carvalho Chehab
2021-10-19 10:50 ` Jeff Layton
2021-10-19 14:14 ` J. Bruce Fields
2021-10-19 15:46 ` Jeff Layton [this message]
2021-10-19 16:16 ` J. Bruce Fields
2021-10-19 16:27 ` Jeff Layton
2021-10-19 17:38 ` [PATCH] locks: remove changelog comments J. Bruce Fields
2021-10-19 18:14 ` Jeff Layton
2021-10-20 5:50 ` Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 19/23] Documentation/process: fix a cross reference Mauro Carvalho Chehab
2021-10-19 8:04 ` [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference Mauro Carvalho Chehab
2021-10-19 16:04 ` Chen-Yu Tsai
2021-10-21 12:12 ` Lee Jones
2021-10-19 8:04 ` [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference Mauro Carvalho Chehab
2021-10-19 8:24 ` Krzysztof Kozlowski
2021-10-19 12:04 ` Mark Brown
2021-10-20 6:30 ` Mauro Carvalho Chehab
2021-10-20 11:04 ` Mark Brown
2021-10-27 2:59 ` Rob Herring
2021-10-19 8:04 ` [PATCH v3 22/23] regulator: dt-bindings: update samsung,s5m8767.yaml reference Mauro Carvalho Chehab
2021-10-19 8:24 ` Krzysztof Kozlowski
2021-10-19 8:04 ` [PATCH v3 23/23] dt-bindings: reserved-memory: ramoops: update ramoops.yaml references Mauro Carvalho Chehab
2021-10-19 9:45 ` David Heidelberg
2021-10-19 16:45 ` Rob Herring
2021-10-19 16:53 ` [PATCH v3 00/23] Fix some issues at documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7bdcf0b279989e51c2c333e89acf3e1d476eff0.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=bfields@fieldses.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).