From: Vidya Sagar <vidyas@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Dinghao Liu <dinghao.liu@zju.edu.cn>, <kjlu@umn.edu>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
<linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error
Date: Wed, 20 May 2020 23:39:08 +0530 [thread overview]
Message-ID: <e7c967a0-c285-450a-bbad-f6456c661d41@nvidia.com> (raw)
In-Reply-To: <20200520163739.GA1100601@bjorn-Precision-5520>
Thanks for pushing a patch to fix it. I've been under the wrong
assumption that a failing pm_runtime_get_sync() wouldn't increment the
usage counter.
With Thierry's and Bjorn's comments addressed
Acked-by: Vidya Sagar <vidyas@nvidia.com>
On 20-May-20 10:07 PM, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
>> On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
>>> pm_runtime_get_sync() increments the runtime PM usage counter even
>>> it returns an error code. Thus a pairing decrement is needed on
>>
>> s/even it/even when it/
>>
>> Might also be a good idea to use a different subject prefix because I
>> was almost not going to look at the other patch, taking this to be a
>> replacement for it.
>
> Amen. This would be a good change to start using "PCI: tegra194" or
> something for pcie-tegra194.c. Or will there be tegra195, tegra 196,
> etc added to this driver?
>
> Also, please capitalize the first word and "PM" in the subjects:
>
> PCI: tegra194: Fix runtime PM imbalance on error
>
> Bjorn
>
next prev parent reply other threads:[~2020-05-20 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:52 [PATCH] PCI: tegra: fix runtime pm imbalance on error Dinghao Liu
2020-05-20 9:59 ` Thierry Reding
2020-05-20 16:37 ` Bjorn Helgaas
2020-05-20 18:09 ` Vidya Sagar [this message]
2020-05-29 10:23 ` Lorenzo Pieralisi
2020-05-29 10:58 ` Vidya Sagar
2020-05-21 3:00 ` dinghao.liu
2020-05-21 3:06 ` dinghao.liu
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 8:40 Dinghao Liu
2020-05-20 9:40 ` Thierry Reding
2020-05-20 16:42 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c967a0-c285-450a-bbad-f6456c661d41@nvidia.com \
--to=vidyas@nvidia.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).