From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934423AbdAKKoW (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 05:44:22 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:23235 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934152AbdAKKoU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 05:44:20 -0500
Subject: Re: [PATCH v2 5/5] ARM: dts: Add LEGO MINDSTORMS EV3 dts
To: David Lechner <david@lechnology.com>
References: <1483677228-2325-1-git-send-email-david@lechnology.com>
 <1483677228-2325-6-git-send-email-david@lechnology.com>
CC: Kevin Hilman <khilman@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <e8136b8a-b8f7-7b1b-693a-955dc17f1de9@ti.com>
Date: Wed, 11 Jan 2017 16:12:52 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1483677228-2325-6-git-send-email-david@lechnology.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 06 January 2017 10:03 AM, David Lechner wrote:

> +	beeper {
> +		compatible = "pwm-beeper";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ehrpwm0b_pins>, <&amp_pins>;
> +		pwms = <&ehrpwm0 1 0 0>;
> +		enable-gpios = <&gpio 111 GPIO_ACTIVE_HIGH>;

Since the enable-gpios binding for pwm beeper is still not accepted, can
you drop the property or the node itself (if that makes more sense)?

> +&spi0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>, <&spi0_cs3_pin>;
> +
> +	flash@0 {
> +		compatible = "n25q128a13", "jedec,spi-nor";
> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +		ti,spi-wdelay = <8>;
> +
> +		/* Partitions are based on the official firmware from LEGO */
> +		partitions {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			partition@0 {
> +				label = "U-Boot";
> +				reg = <0 0x40000>;
> +			};
> +
> +			partition@40000 {
> +				label = "U-Boot Env";
> +				reg = <0x40000 0x10000>;
> +			};
> +
> +			partition@50000 {
> +				label = "Kernel";
> +				reg = <0x50000 0x200000>;
> +			};
> +
> +			partition@250000 {
> +				label = "Filesystem";
> +				reg = <0x250000 0xa50000>;
> +			};
> +
> +			partition@cb0000 {
> +				label = "Storage";
> +				reg = <0xcb0000 0x2f0000>;
> +			};
> +		};
> +	};
> +
> +	adc@3 {
> +		compatible = "ti-ads7957";

So looks like this works because of_register_spi_device() sets up
modalias of spi device from compatible string. I am fine with it, just
highlighting it here to make sure this is acceptable practice. I did not
really find any precedence for using SPI device name as compatible
property in existing DTS files.

> +		reg = <3>;
> +		spi-max-frequency = <10000000>;
> +		refin-supply = <&adc_ref>;
> +	};

Rest of the patch looks good to me.

Thanks,
Sekhar