linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	peterhuewe@gmx.de, Nayna Jain <nayna@linux.ibm.com>,
	George Wilson <gcwilson@linux.ibm.com>
Subject: Re: [PATCH] tpm: ibmvtpm: Avoid -EINTR error when IMA talks to TPM
Date: Fri, 12 Feb 2021 17:32:14 -0500	[thread overview]
Message-ID: <e850c8e8-76ab-548c-1f45-6e68d9faecac@linux.ibm.com> (raw)
In-Reply-To: <YCZE8nf9ylXJTo4k@kernel.org>

On 2/12/21 4:05 AM, Jarkko Sakkinen wrote:
> On Tue, Feb 09, 2021 at 05:13:39PM -0500, Stefan Berger wrote:
>> When IMA is taking measurements during compilation for example and a
>> user presses ctrl-c to abort the compilation, lots of these types of
>> messages will appear in the kernel log:
>>
>> [ 7406.275163] tpm tpm0: tpm_transmit: tpm_recv: error -4
>> [ 7406.275242] ima: Error Communicating to TPM chip, result: -4
>>
>> The issue is caused by the fact that the IBM vTPM driver's recv()
>> function is called immediately after send() without waiting for
>> status on whether a response was received. It currently waits for
>> the current command to finish using this call that ends up throwing
>> these error messages because it is 'interruptible':
> Why it is an issue?


The issue is the many kernel log entries we get when someone interrupts 
an application with ctrl-c while IMA is taking measurements of files it 
reads.I thought that was clear from the first paragraph.



      reply	other threads:[~2021-02-12 22:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 22:13 [PATCH] tpm: ibmvtpm: Avoid -EINTR error when IMA talks to TPM Stefan Berger
2021-02-12  9:05 ` Jarkko Sakkinen
2021-02-12 22:32   ` Stefan Berger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e850c8e8-76ab-548c-1f45-6e68d9faecac@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=gcwilson@linux.ibm.com \
    --cc=jarkko@kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nayna@linux.ibm.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).