From: Dan Murphy <dmurphy@ti.com>
To: Wolfgang Grandegger <wg@grandegger.com>, <mkl@pengutronix.de>,
<davem@davemloft.net>
Cc: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] can: m_can: Rename m_can_priv to m_can_classdev
Date: Fri, 8 Mar 2019 06:33:49 -0600 [thread overview]
Message-ID: <e85a4d42-2c96-a95c-e3bb-31a3c928a1f2@ti.com> (raw)
In-Reply-To: <1138f22c-028c-184a-19c0-5b8f64bd977f@grandegger.com>
Wolfgang
On 3/8/19 4:25 AM, Wolfgang Grandegger wrote:
>
>
> Am 05.03.19 um 16:52 schrieb Dan Murphy:
>> Rename the common m_can_priv class structure to
>> m_can_classdev as this is more descriptive.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v7 - Fixed remaining checkpatch issues, renamed priv to cdev - https://lore.kernel.org/patchwork/patch/1047219/
>>
>> v6 - No changes only rebase changes possibly can squash into the first patch -
>> https://lore.kernel.org/patchwork/patch/1042444/
>>
>> drivers/net/can/m_can/m_can.c | 524 ++++++++++++-------------
>> drivers/net/can/m_can/m_can.h | 28 +-
>> drivers/net/can/m_can/m_can_platform.c | 16 +-
>> 3 files changed, 284 insertions(+), 284 deletions(-)
>
> ...snip...
>
>> diff --git a/drivers/net/can/m_can/m_can.h b/drivers/net/can/m_can/m_can.h
>> index b60f27dd9f33..1299cc747194 100644
>> --- a/drivers/net/can/m_can/m_can.h
>> +++ b/drivers/net/can/m_can/m_can.h
>> @@ -57,19 +57,19 @@ struct mram_cfg {
>> u8 num;
>> };
>>
>> -struct m_can_priv;
>> +struct m_can_classdev;
>> struct m_can_ops {
>> /* Device specific call backs */
>> - int (*clear_interrupts)(struct m_can_priv *m_can_class);
>> - u32 (*read_reg)(struct m_can_priv *m_can_class, int reg);
>> - int (*write_reg)(struct m_can_priv *m_can_class, int reg, int val);
>> - u32 (*read_fifo)(struct m_can_priv *m_can_class, int addr_offset);
>> - int (*write_fifo)(struct m_can_priv *m_can_class, int addr_offset,
>> + int (*clear_interrupts)(struct m_can_classdev *m_can_class);
>> + u32 (*read_reg)(struct m_can_classdev *m_can_class, int reg);
>> + int (*write_reg)(struct m_can_classdev *m_can_class, int reg, int val);
>> + u32 (*read_fifo)(struct m_can_classdev *m_can_class, int addr_offset);
>> + int (*write_fifo)(struct m_can_classdev *m_can_class, int addr_offset,
>
> Could you please replace the variable name "m_can_class" with "cdev"
> here and below and in "c_can_platform.c " and "tcan4x5x.c" as well.
>
OK I will update the header
The tcan and m_can_platform source files are converted to cdev as opposed to m_can_class variable.
Dan
> Thanks,
>
> Wolfgang.
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-03-08 12:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 15:52 [PATCH v7 1/4] can: m_can: Create a m_can platform framework Dan Murphy
2019-03-05 15:52 ` [PATCH v7 2/4] can: m_can: Rename m_can_priv to m_can_classdev Dan Murphy
2019-03-08 10:25 ` Wolfgang Grandegger
2019-03-08 12:33 ` Dan Murphy [this message]
2019-03-05 15:52 ` [PATCH v7 3/4] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2019-03-05 15:52 ` [PATCH v7 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2019-03-08 10:10 ` [PATCH v7 1/4] can: m_can: Create a m_can platform framework Wolfgang Grandegger
2019-03-08 12:44 ` Dan Murphy
2019-03-08 13:29 ` Wolfgang Grandegger
2019-03-08 14:41 ` Wolfgang Grandegger
2019-03-08 15:48 ` Dan Murphy
2019-03-08 17:08 ` Wolfgang Grandegger
2019-03-08 17:25 ` Dan Murphy
2019-03-08 17:40 ` Wolfgang Grandegger
2019-03-08 17:52 ` Dan Murphy
2019-03-08 18:06 ` Wolfgang Grandegger
2019-03-08 20:36 ` Dan Murphy
2019-03-11 11:19 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e85a4d42-2c96-a95c-e3bb-31a3c928a1f2@ti.com \
--to=dmurphy@ti.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).