From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932933AbeCMN3a (ORCPT ); Tue, 13 Mar 2018 09:29:30 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:27512 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932706AbeCMN31 (ORCPT ); Tue, 13 Mar 2018 09:29:27 -0400 Subject: Re: [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable To: Arnd Bergmann , Mauro Carvalho Chehab CC: Hans Verkuil , Sakari Ailus , , References: <20180313120548.2603484-1-arnd@arndb.de> From: Peter Ujfalusi Message-ID: Date: Tue, 13 Mar 2018 15:29:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180313120548.2603484-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-03-13 14:05, Arnd Bergmann wrote: > We now get a warning after the 'dmadev' variable is no longer used: > > drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb': > drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable 'dmadev' [-Werror=unused-variable] > > Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()") > Signed-off-by: Arnd Bergmann Reviewed-by: Peter Ujfalusi > --- > drivers/media/platform/omap/omap_vout_vrfb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c b/drivers/media/platform/omap/omap_vout_vrfb.c > index 72c0ac2cbf3d..1d8508237220 100644 > --- a/drivers/media/platform/omap/omap_vout_vrfb.c > +++ b/drivers/media/platform/omap/omap_vout_vrfb.c > @@ -236,7 +236,6 @@ int omap_vout_prepare_vrfb(struct omap_vout_device *vout, > struct dma_async_tx_descriptor *tx; > enum dma_ctrl_flags flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK; > struct dma_chan *chan = vout->vrfb_dma_tx.chan; > - struct dma_device *dmadev = chan->device; > struct dma_interleaved_template *xt = vout->vrfb_dma_tx.xt; > dma_cookie_t cookie; > enum dma_status status; > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki