From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
Konrad Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH] xen/tmem: cleanup
Date: Mon, 6 Feb 2012 08:37:17 -0800 (PST) [thread overview]
Message-ID: <e871af1b-8003-4d3d-8fde-ea40545ff9fe@default> (raw)
In-Reply-To: <4F2F998202000078000714CD@nat28.tlf.novell.com>
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Monday, February 06, 2012 1:13 AM
> To: Dan Magenheimer
> Cc: Jeremy Fitzhardinge; xen-devel@lists.xensource.com; Konrad Wilk; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] xen/tmem: cleanup
>
> >>> On 04.02.12 at 17:42, Dan Magenheimer <dan.magenheimer@oracle.com> wrote:
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Subject: [PATCH] xen/tmem: cleanup
> >>
> >> Use 'bool' for boolean variables. Do proper section placement.
> >> Eliminate an unnecessary export.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
> >>
> >> -int tmem_enabled __read_mostly;
> >> -EXPORT_SYMBOL(tmem_enabled);
> >> +bool __read_mostly tmem_enabled = false;
> >
> > tmem_enabled is used in xen/drivers/xen-selfballoon.c
>
> Which can't be built as a module, and hence the symbol doesn't need
> exporting. This patch (of course, I'm tempted to say) survived build
> testing.
Yes, correct. BUT... I think only the reason xen-selfballoon.c
can't be built as a module is because the MM variable vm_committed_as
(or an access function) is not exported. Ideally xen-selfballoon.c
probably should be a module but putting a core MM change in
the critical path of a Xen-only-related enhancement seemed
a recipe for sure failure.
Konrad, if you (1) disagree entirely, or (2) want to remove the
tmem_enabled EXPORT_SYMBOL now and add it back later if/when
the core MM change happens, I'll leave that up to you.
If (2), the MM change should be added to the minor-tmem-related-
changes-that-need-to-be-eventually-upstreamed list ;-)
Dan
next prev parent reply other threads:[~2012-02-06 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 15:09 [PATCH] xen/tmem: cleanup Jan Beulich
2012-02-04 16:42 ` Dan Magenheimer
2012-02-06 8:12 ` Jan Beulich
2012-02-06 16:37 ` Dan Magenheimer [this message]
2012-02-06 16:49 ` Jan Beulich
2012-02-06 17:02 ` Konrad Rzeszutek Wilk
2012-02-06 17:22 ` Dan Magenheimer
2012-02-09 20:15 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-02-07 7:51 ` Jan Beulich
2012-02-07 10:23 ` [Xen-devel] " Vasiliy Tolstov
2012-02-09 20:40 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e871af1b-8003-4d3d-8fde-ea40545ff9fe@default \
--to=dan.magenheimer@oracle.com \
--cc=JBeulich@suse.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).