From: liaoweixiong <liaoweixiong@allwinnertech.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 3/4] pstore/blk: support pmsg for pstore block
Date: Thu, 7 Mar 2019 09:05:32 +0800 [thread overview]
Message-ID: <e88aed98-a96b-6e78-9183-5ff50dfa64e7@allwinnertech.com> (raw)
In-Reply-To: <a7ae72c0-2425-a43a-da53-22f30a173f7e@infradead.org>
Hi,
On 2019-03-06 09:16, Randy Dunlap wrote:
> Hi,
>
> On 2/27/19 11:12 PM, liaoweixiong wrote:
>> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
>> index 7dfe00b..b417bf5 100644
>> --- a/fs/pstore/Kconfig
>> +++ b/fs/pstore/Kconfig
>> @@ -210,6 +210,27 @@ config PSTORE_BLKOOPS_DMESG_SIZE
>> It is the first priority. Take care of that blkoops will take lower
>> priority settings if higher priority one do not set.
>>
>> +config PSTORE_BLKOOPS_PMSG_SIZE
>> + int "pmsg size in kbytes for blkoops"
>> + depends on PSTORE_BLKOOPS
>> + default 64
>> + help
>> + This just sets size of pmsg (pmsg_size) for pstore/blk. The value must
>> + be a multiple of 4096. Pmsg work only if "blkdev" is set.
>
> works
>
Fixed.
>> +
>> + NOTE that, there are three ways to set parameters of blkoops and
>> + prioritize according to configuration flexibility. That is
>> + Kconfig < device tree < module parameters. It means that the value can
>> + be overwritten by higher priority settings.
>> + 1. Kconfig
>> + It just sets a default value.
>> + 2. device tree
>> + It is set on device tree, which will overwrites value from Kconfig,
>
> overwrite the value from Kconfig,
>
Fixed.
>> + but can also be overwritten by module parameters.
>> + 3. module parameters
>> + It is the first priority. Take care of that blkoops will take lower
>> + priority settings if higher priority one do not set.
>> +
>> config PSTORE_BLKOOPS_TOTAL_SIZE
>> int "total size in kbytes for blkoops"
>> depends on PSTORE_BLKOOPS
>
> cheers.
>
Thank you. Cheers.
--
liaoweixiong
next prev parent reply other threads:[~2019-03-07 1:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 7:12 [PATCH v12 0/4] pstore/block: new support logger for block devices liaoweixiong
2019-02-28 7:12 ` [PATCH v12 1/4] pstore/blk: " liaoweixiong
2019-03-05 7:12 ` Dan Carpenter
2019-03-05 12:29 ` liaoweixiong
2019-02-28 7:12 ` [PATCH v12 2/4] pstore/blk: add blkoops for pstore_blk liaoweixiong
2019-03-06 1:14 ` Randy Dunlap
2019-03-07 1:01 ` liaoweixiong
2019-02-28 7:12 ` [PATCH v12 3/4] pstore/blk: support pmsg for pstore block liaoweixiong
2019-03-06 1:16 ` Randy Dunlap
2019-03-07 1:05 ` liaoweixiong [this message]
2019-02-28 7:12 ` [PATCH v12 4/4] Documentation: pstore/blk: create document for pstore_blk liaoweixiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88aed98-a96b-6e78-9183-5ff50dfa64e7@allwinnertech.com \
--to=liaoweixiong@allwinnertech.com \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).