From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB2DC433ED for ; Tue, 18 May 2021 04:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E26B6112F for ; Tue, 18 May 2021 04:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233412AbhERECo (ORCPT ); Tue, 18 May 2021 00:02:44 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3014 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbhERECm (ORCPT ); Tue, 18 May 2021 00:02:42 -0400 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Fkj183rCwzlfn2; Tue, 18 May 2021 11:59:08 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 18 May 2021 12:01:23 +0800 Received: from [127.0.0.1] (10.40.192.162) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 18 May 2021 12:01:23 +0800 Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments To: Johan Hovold References: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com> <1621233433-27094-7-git-send-email-tanxiaofei@huawei.com> CC: , , , , From: Xiaofei Tan Message-ID: Date: Tue, 18 May 2021 12:01:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.192.162] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Thanks for reviewing this patch. On 2021/5/17 22:15, Johan Hovold wrote: > On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote: >> Fix coding style issues of block comments, reported by checkpatch.pl. >> Besides, add a period at the end of the sentenses. >> >> Signed-off-by: Xiaofei Tan >> --- >> drivers/tty/hvc/hvc_console.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c >> index 39018e5..a61cdf0 100644 >> --- a/drivers/tty/hvc/hvc_console.c >> +++ b/drivers/tty/hvc/hvc_console.c >> @@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b, >> r = cons_ops[index]->put_chars(vtermnos[index], c, i); >> if (r <= 0) { >> /* throw away characters on error >> - * but spin in case of -EAGAIN */ >> + * but spin in case of -EAGAIN. >> + */ > > How is this an improvement? First, the multi-line comment style is > > /* > * ... > */ > Yes, mostly we use this style. I can follow it if new version is needed. BTW, How about add the '/*' check into checkpatch.pl? > Second, that sentence is not capitalised so why do add a period? > How about capitalize the sentence, or just remove the period ? > Third, why are you sending checkpatch.pl cleanups for files outside of > staging? > I'm sorry, Is this a rule, or kind of tradition? I've never heard of this before. > Unless doing some real changes to the files in question as well this is > mostly just churn and noise that makes it harder to backport fixes and > do code forensics for no real gain. > I'm not sure. But if cleanup patches have made it hard to backport fixes and do code forensics, then the code quality may not be good enough. > Greg may disagree, but I don't think we should be encouraging this kind > of patches. > > Johan > > . >