From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexandre Bailon <abailon@baylibre.com>,
david@lechnology.com, b-liu@ti.com, balbi@kernel.org
Cc: kishon@ti.com, khilman@baylibre.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
nsekhar@ti.com
Subject: Re: [PATCH v4 3/4] usb: musb: Add a quirk flag to skip the phy set mode
Date: Fri, 4 Nov 2016 23:20:31 +0300 [thread overview]
Message-ID: <e8a19215-bcd5-71ec-42f0-f55c17164bea@cogentembedded.com> (raw)
In-Reply-To: <1478277818-5091-4-git-send-email-abailon@baylibre.com>
Hello.
On 11/04/2016 07:43 PM, Alexandre Bailon wrote:
> During the init, the driver will use the mode to configure
> the controller mode and the phy mode.
PHY -- be consistent please...
> The PHY of DA8xx has some issues when the phy is forced in host or device.
Again.
> Add way to skip the set mode and let the da8xx glue manage the phy mode.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> drivers/usb/musb/musb_core.c | 15 ++++++++++-----
> drivers/usb/musb/musb_core.h | 1 +
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 27dadc0..6f5f039 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
[...]
> @@ -2278,15 +2279,19 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
[...]
> - if (status < 0)
> - goto fail3;
> + if (mode != MUSB_UNDEFINED &&
> + !(musb->io.quirks & MUSB_SKIP_SET_MODE)) {
Please either add one more tab here or align to 'mode', so it's easier on
the eyes.
> + status = musb_platform_set_mode(musb, mode);
> + if (status < 0)
> + goto fail3;
> + }
>
> status = musb_init_debugfs(musb);
> if (status < 0)
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-11-04 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 16:43 [PATCH v4 0/4] usb: musb: da8xx: Fix few issues Alexandre Bailon
2016-11-04 16:43 ` [PATCH v4 1/4] usb: musb: da8xx: Call earlier clk_prepare_enable() Alexandre Bailon
2016-11-04 16:43 ` [PATCH v4 2/4] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround Alexandre Bailon
2016-11-04 16:43 ` [PATCH v4 3/4] usb: musb: Add a quirk flag to skip the phy set mode Alexandre Bailon
2016-11-04 18:51 ` David Lechner
2016-11-04 20:20 ` Sergei Shtylyov [this message]
2016-11-04 16:43 ` [PATCH v4 4/4] usb: musb: da8xx: Set phy in OTG mode by default Alexandre Bailon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a19215-bcd5-71ec-42f0-f55c17164bea@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=abailon@baylibre.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=david@lechnology.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).