From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gatis Peisenieks <gatis@mikrotik.com>,
chris.snook@gmail.com, davem@davemloft.net, kuba@kernel.org,
hkallweit1@gmail.com, jesse.brandeburg@intel.com,
dchickles@marvell.com, tully@mikrotik.com,
eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] atl1c: move tx cleanup processing out of interrupt
Date: Fri, 2 Apr 2021 20:05:22 +0200 [thread overview]
Message-ID: <e8b35b3e-ee20-412b-b2cd-5362e4282abf@gmail.com> (raw)
In-Reply-To: <c6ea0a3d1bcf79bb1e319d1e99cfed9b@mikrotik.com>
On 4/2/21 7:20 PM, Gatis Peisenieks wrote:
> Tx queue cleanup happens in interrupt handler on same core as rx queue processing.
> Both can take considerable amount of processing in high packet-per-second scenarios.
>
> Sending big amounts of packets can stall the rx processing which is unfair
> and also can lead to to out-of-memory condition since __dev_kfree_skb_irq
> queues the skbs for later kfree in softirq which is not allowed to happen
> with heavy load in interrupt handler.
>
> This puts tx cleanup in its own napi and enables threaded napi to allow the rx/tx
> queue processing to happen on different cores.
>
> The ability to sustain equal amounts of tx/rx traffic increased:
> from 280Kpps to 1130Kpps on Threadripper 3960X with upcoming Mikrotik 10/25G NIC,
> from 520Kpps to 850Kpps on Intel i3-3320 with Mikrotik RB44Ge adapter.
>
> Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
> ---
> drivers/net/ethernet/atheros/atl1c/atl1c.h | 2 +
> .../net/ethernet/atheros/atl1c/atl1c_main.c | 43 +++++++++++++++++--
> 2 files changed, 41 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c.h b/drivers/net/ethernet/atheros/atl1c/atl1c.h
> index a0562a90fb6d..4404fa44d719 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c.h
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c.h
> @@ -506,6 +506,7 @@ struct atl1c_adapter {
> struct net_device *netdev;
> struct pci_dev *pdev;
> struct napi_struct napi;
> + struct napi_struct tx_napi;
> struct page *rx_page;
> unsigned int rx_page_offset;
> unsigned int rx_frag_size;
> @@ -529,6 +530,7 @@ struct atl1c_adapter {
> u16 link_duplex;
>
> spinlock_t mdio_lock;
> + spinlock_t irq_mask_lock;
> atomic_t irq_sem;
>
> struct work_struct common_task;
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 3f65f2b370c5..f51b28e8b6dc 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -813,6 +813,7 @@ static int atl1c_sw_init(struct atl1c_adapter *adapter)
> atl1c_set_rxbufsize(adapter, adapter->netdev);
> atomic_set(&adapter->irq_sem, 1);
> spin_lock_init(&adapter->mdio_lock);
> + spin_lock_init(&adapter->irq_mask_lock);
> set_bit(__AT_DOWN, &adapter->flags);
>
> return 0;
> @@ -1530,7 +1531,7 @@ static inline void atl1c_clear_phy_int(struct atl1c_adapter *adapter)
> spin_unlock(&adapter->mdio_lock);
> }
>
> -static bool atl1c_clean_tx_irq(struct atl1c_adapter *adapter,
> +static unsigned atl1c_clean_tx_irq(struct atl1c_adapter *adapter,
> enum atl1c_trans_queue type)
This v2 is much better, thanks.
You might rename this atl1c_clean_tx_irq(), because it is now
not run under hard irqs ?
Maybe merge atl1c_clean_tx_irq() and atl1c_clean_tx() into a single function ?
next prev parent reply other threads:[~2021-04-02 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 17:20 [PATCH net v2] atl1c: move tx cleanup processing out of interrupt Gatis Peisenieks
2021-04-02 18:05 ` Eric Dumazet [this message]
2021-04-02 18:20 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b35b3e-ee20-412b-b2cd-5362e4282abf@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=gatis@mikrotik.com \
--cc=hkallweit1@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tully@mikrotik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).