From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] device.h: pack struct dev_links_info
Date: Tue, 26 Feb 2019 16:40:39 +0100 [thread overview]
Message-ID: <e8bee9db-bd73-6352-9e0f-f3471b9584ae@intel.com> (raw)
In-Reply-To: <20190226144108.25891-1-gregkh@linuxfoundation.org>
On 2/26/2019 3:41 PM, Greg Kroah-Hartman wrote:
> The dev_links_info structure has 4 bytes of padding at the end of it
> when embedded in struct device (which is the only place it lives). To
> help reduce the size of struct device pack this structure so we can take
> advantage of the hole with later structure reorganizations.
>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> include/linux/device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 6cb4640b6160..b63165276a09 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -884,7 +884,7 @@ struct dev_links_info {
> struct list_head suppliers;
> struct list_head consumers;
> enum dl_dev_state status;
> -};
> +} __packed;
>
> /**
> * struct device - The basic device structure
next prev parent reply other threads:[~2019-02-26 15:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:41 [PATCH 1/2] device.h: pack struct dev_links_info Greg Kroah-Hartman
2019-02-26 14:41 ` [PATCH 2/2] device.h: reorganize struct device Greg Kroah-Hartman
2019-02-26 15:40 ` Rafael J. Wysocki [this message]
2019-02-27 9:23 ` [PATCH 1/2] device.h: pack struct dev_links_info Johan Hovold
2019-02-27 9:31 ` Greg Kroah-Hartman
2019-02-27 9:40 ` Johan Hovold
2019-02-27 9:54 ` Greg Kroah-Hartman
2019-02-27 10:59 ` Johan Hovold
2019-02-27 12:06 ` Greg Kroah-Hartman
2019-02-27 13:32 ` Johan Hovold
2019-02-28 8:35 ` Greg Kroah-Hartman
2019-02-28 23:43 ` Rafael J. Wysocki
2019-02-28 13:58 ` [PATCH v2] device.h: reorganize struct device Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8bee9db-bd73-6352-9e0f-f3471b9584ae@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).