From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751236AbdAQUtq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Jan 2017 15:49:46 -0500
Received: from mx2.suse.de ([195.135.220.15]:49054 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750830AbdAQUtm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2017 15:49:42 -0500
Subject: Re: [PATCH -next] init/main: Init jump_labels before they are used to
 build zonelists
To: Andrew Morton <akpm@linux-foundation.org>
References: <20170117125624.8535-1-shorne@gmail.com>
 <cc2486a7-4a95-8014-acfa-0eedf485d935@suse.cz>
 <20170117134454.GB6515@twins.programming.kicks-ass.net>
 <20170117143043.GA7836@lianli.shorne-pla.net>
 <8c4e1c37-1a8e-9e5e-c276-f7bd3cfb248b@suse.cz>
 <20170117123416.6d0caf7544a3508d368ecea1@linux-foundation.org>
Cc: Stafford Horne <shorne@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Kees Cook <keescook@chromium.org>, Jessica Yu <jeyu@redhat.com>,
        Petr Mladek <pmladek@suse.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Yang Shi <yang.shi@linaro.org>, Tejun Heo <tj@kernel.org>,
        Prarit Bhargava <prarit@redhat.com>,
        Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <e8d8db10-ff33-0dd9-f954-8bc069b239a6@suse.cz>
Date: Tue, 17 Jan 2017 21:49:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170117123416.6d0caf7544a3508d368ecea1@linux-foundation.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17.1.2017 21:34, Andrew Morton wrote:
>>>
>>> Will you be able to look into that? Openrisc doesnt have jump_label
>>> support, so its no issue at the moment.
>>>
>>> Archs that do have it:
>>>
>>> arch/arm64/Kconfig:     select HAVE_ARCH_JUMP_LABEL
>>> arch/mips/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/s390/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/sparc/Kconfig:     select HAVE_ARCH_JUMP_LABEL if SPARC64
>>> arch/tile/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/x86/Kconfig:       select HAVE_ARCH_JUMP_LABEL
>>> arch/arm/Kconfig:       select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU
>>> arch/powerpc/Kconfig:   select HAVE_ARCH_JUMP_LABEL
>>>
>>> I looked at a few (arm, tile) and I dont see their arch_jump_label_transform*
>>> implementations depending on global state like ideal_nops from x86. They
>>> should be ok.
>>
>> Thanks, I'll try.
>>
>>> If no time, Should you change your patch to not use static keys for
>>> build_all_zonelists at least?
>>
>> Yes that would be uglier but possible if I find issues or I'm not
>> confident enough with the auditing...
> 
> We could just revert f5adbdff6a1c40e19 ("mm, page_alloc: convert
> page_group_by_mobility_disable to static key")?

That's a -next commit id, as the patch is in mmotm. I'll ask for removal if I
don't have a fix soon, but if you or somebody else prefers to do that ASAP, it
can be re-added later with a fix.