From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Vatsala Narang <vatsalanarang@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Julia.Lawall@lip6.fr
Subject: Re: [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake
Date: Fri, 26 Apr 2019 10:31:27 -0500 [thread overview]
Message-ID: <e8f91496-8b72-03f9-d70f-edded16bb53f@embeddedor.com> (raw)
In-Reply-To: <20190426084303.30646-1-vatsalanarang@gmail.com>
Hi Vatsala,
On 4/26/19 3:43 AM, Vatsala Narang wrote:
> Replace explicitely with explicitly to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> Changes in v2:
> -added this patch to patchset to fix spelling mistake.
>
When you create a series, it is a good thing to include a cover letter,
in particular in cases like this, in which there is no v1 of this
patch. Notice that you have just created a v2 of a previously
non-existent series. This can create confusion for maintainers
were you addressing a more complex task.
I might be a bit picky here, but be sure that any extra time you
invest in the first stages as a kernel contributor will pay off
in the future. :)
Anyway, here is my
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
for both patches.
Thanks and keep contributing.
--
Gustavo
> drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> index 2044ae27b973..9631331b79d5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -396,7 +396,8 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee,
> (*crypt)->priv);
> sec.flags |= BIT(key);
> /* This ensures a key will be activated if no key is
> - * explicitely set */
> + * explicitly set
> + */
> if (key == sec.active_key)
> sec.flags |= SEC_ACTIVE_KEY;
> ieee->tx_keyidx = key;
>
prev parent reply other threads:[~2019-04-26 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 8:43 [PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake Vatsala Narang
2019-04-26 15:31 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f91496-8b72-03f9-d70f-edded16bb53f@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=Julia.Lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).