linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Sonny Rao <sonnyrao@google.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
	Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org,
	Dmitry Shmidt <dimitrysh@google.com>,
	Amit Pundir <amit.pundir@linaro.org>,
	kernel-team@android.com, Jesse Barnes <jsbarnes@google.com>,
	vpillai@digitalocean.com, Peter Zijlstra <peterz@infradead.org>,
	Guenter Roeck <groeck@chromium.org>,
	Greg Kerr <kerrnel@google.com>,
	cgroups@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
	Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH RFC] cpuset: Make cpusets get restored on hotplug
Date: Thu, 26 Mar 2020 17:47:36 -0400	[thread overview]
Message-ID: <e9093ab2-f61f-edf1-5da7-fce5101d6dbf@redhat.com> (raw)
In-Reply-To: <CAPz6YkVUsDz456z8-X2G_EDd-uet1rRNnh2sDUpdcoWp_fkDDw@mail.gmail.com>

On 3/26/20 4:05 PM, Sonny Rao wrote:
>> I think Tejun is concerned about a change in the default behavior of
>> cpuset v1.
>>
>> There is a special v2 mode for cpuset that is enabled by the mount
>> option "cpuset_v2_mode". This causes the cpuset v1 to adopt some of the
>> v2 behavior. I introduced this v2 mode a while back to address, I think,
>> a similar concern. Could you try that to see if it is able to address
>> your problem? If not, you can make some code adjustment within the
>> framework of the v2 mode. As long as it is an opt-in, I think we are
>> open to further change.
> I am surprised if anyone actually wants this behavior, we (Chrome OS)
> found out about it accidentally, and then found that Android had been
> carrying a patch to fix it.  And if it were a desirable behavior then
> why isn't it an option in v2?
>
I am a bit confused. The v2 mode make cpuset v1 behaves more like cpuset
v2. The original v1 behavior has some obvious issue that was fixed in
v2. So what v2 option are you talking about?

Regards,
Longman


  parent reply	other threads:[~2020-03-26 21:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 19:16 [PATCH RFC] cpuset: Make cpusets get restored on hotplug Joel Fernandes (Google)
2020-03-26 19:20 ` Tejun Heo
2020-03-26 19:44   ` Joel Fernandes
2020-03-26 19:48     ` Tejun Heo
2020-03-26 19:57     ` Waiman Long
2020-03-26 20:05       ` Sonny Rao
2020-03-26 20:18         ` Tejun Heo
2020-03-26 20:23           ` Joel Fernandes
2020-03-27  1:26             ` Waiman Long
2020-03-27  3:32               ` Joel Fernandes
2020-03-26 21:47         ` Waiman Long [this message]
2020-03-26 22:03           ` Sonny Rao
2021-10-26 23:58       ` Barry Song
2021-10-27  1:06         ` Waiman Long
2021-10-27  2:21           ` Barry Song
2021-10-27  2:35             ` Waiman Long
2021-10-27  2:42               ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9093ab2-f61f-edf1-5da7-fce5101d6dbf@redhat.com \
    --to=longman@redhat.com \
    --cc=amit.pundir@linaro.org \
    --cc=cgroups@vger.kernel.org \
    --cc=dimitrysh@google.com \
    --cc=groeck@chromium.org \
    --cc=hannes@cmpxchg.org \
    --cc=joel@joelfernandes.org \
    --cc=jsbarnes@google.com \
    --cc=kernel-team@android.com \
    --cc=kerrnel@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=peterz@infradead.org \
    --cc=sonnyrao@google.com \
    --cc=tj@kernel.org \
    --cc=vpillai@digitalocean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).