From: Lars-Peter Clausen <lars@metafoo.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] iio: adc: ad7768-1: Fix the right interrupt interface calls
Date: Tue, 11 May 2021 18:29:36 +0200 [thread overview]
Message-ID: <e923eaea-bd62-2395-5c71-92eb9d849fd5@metafoo.de> (raw)
In-Reply-To: <20210511153108.14816-1-tangbin@cmss.chinamobile.com>
On 5/11/21 5:31 PM, Tang Bin wrote:
> In the function ad7768_probe(), the devm_request_irq() should
> call ad7768_interrupt, not &ad7768_interrupt, so fix this mistake.
>
> Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Hi,
Thanks for the patch. Aren't those two expressions equivalent? Are you
seeing an issue with the current code? If so can you include that in the
commit message?
- Lars
> ---
> drivers/iio/adc/ad7768-1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index 0e93b0766..9c9ab56d6 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -605,7 +605,7 @@ static int ad7768_probe(struct spi_device *spi)
> init_completion(&st->completion);
>
> ret = devm_request_irq(&spi->dev, spi->irq,
> - &ad7768_interrupt,
> + ad7768_interrupt,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> indio_dev->name, indio_dev);
> if (ret)
next prev parent reply other threads:[~2021-05-11 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 15:31 [PATCH] iio: adc: ad7768-1: Fix the right interrupt interface calls Tang Bin
2021-05-11 16:29 ` Lars-Peter Clausen [this message]
2021-05-12 8:39 ` [PATCH] iio: adc: ad7768-1: Fix the right interrupt interfacecalls tangbin
2021-05-12 9:21 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e923eaea-bd62-2395-5c71-92eb9d849fd5@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).