From: Markus Elfring <Markus.Elfring@web.de>
To: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Heiko Stübner" <heiko@sntech.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll()
Date: Sat, 12 Oct 2019 15:55:44 +0200 [thread overview]
Message-ID: <e96505a8-b554-f61e-3940-0b9e9c7850ff@web.de> (raw)
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rockchip_clk_register_pll” contains also a call
of the function “kmemdup”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/rockchip/clk-pll.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n913
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/rockchip/clk-pll.c#L913
* Do you find the usage of the format string “%s: could not allocate
rate table for %s\n” still appropriate at this place?
* Is there a need to adjust the error handling here?
Regards,
Markus
next reply other threads:[~2019-10-12 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 13:55 Markus Elfring [this message]
2019-10-12 21:32 ` clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll() Heiko Stübner
2019-10-13 8:45 ` Markus Elfring
2019-10-13 21:49 ` Heiko Stuebner
2019-10-14 7:26 ` Markus Elfring
2019-10-15 20:29 ` Heiko Stuebner
2019-10-16 6:24 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e96505a8-b554-f61e-3940-0b9e9c7850ff@web.de \
--to=markus.elfring@web.de \
--cc=emamd001@umn.edu \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=pakki001@umn.edu \
--cc=sboyd@kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).