linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Songjun Wu <songjun.wu@atmel.com>,
	laurent.pinchart@ideasonboard.com, nicolas.ferre@atmel.com,
	boris.brezillon@free-electrons.com,
	alexandre.belloni@free-electrons.com, robh@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Richard Röjfors" <richard@puffinpack.se>,
	"Benoit Parrot" <bparrot@ti.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	"Mikhail Ulyanov" <mikhail.ulyanov@cogentembedded.com>,
	"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-media@vger.kernel.org,
	"Simon Horman" <horms+renesas@verge.net.au>
Subject: Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC
Date: Fri, 1 Jul 2016 14:20:14 +0200	[thread overview]
Message-ID: <e96fe150-2e5c-5ffa-3c1b-99e55fa4bff0@xs4all.nl> (raw)
In-Reply-To: <1466153854-30272-1-git-send-email-songjun.wu@atmel.com>

Hi Songjun,

First of all, please CC patch 2/2 to linux-media as well the next time you post this.
I only see 1/2 on the mailinglist, and we need both.

Secondly, before I can accept it you need to run the v4l2-compliance test first and
I need to see the output of that test.

The compliance test is here: https://git.linuxtv.org/v4l-utils.git. Always compile it from
the repository so you know you are using the latest most up to date version.

Since this driver supports multiple pixelformats you need to test with the -f option,
which tests streaming for all pixelformats.

Obviously, there shouldn't be any FAILs :-)

I greatly simplifies the code review if I know it passes the compliance test.

Regards,

	Hans

  parent reply	other threads:[~2016-07-01 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  8:57 [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC Songjun Wu
2016-06-17  8:57 ` [PATCH v5 1/2] [media] atmel-isc: add the Image Sensor Controller code Songjun Wu
2016-06-17  8:57 ` [PATCH v5 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver Songjun Wu
2016-06-20 13:25   ` Rob Herring
2016-06-24  5:54     ` Wu, Songjun
2016-06-24  7:35       ` Boris Brezillon
2016-06-24  8:56         ` Wu, Songjun
2016-07-01 12:20 ` Hans Verkuil [this message]
2016-07-04  3:04   ` [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC Wu, Songjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96fe150-2e5c-5ffa-3c1b-99e55fa4bff0@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=horms+renesas@verge.net.au \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mikhail.ulyanov@cogentembedded.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=pawel.moll@arm.com \
    --cc=peter.griffin@linaro.org \
    --cc=richard@puffinpack.se \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=songjun.wu@atmel.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).