From: Atish Patra <atish.patra@wdc.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <anup@brainfault.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Dmitriy Cherkasov <dmitriy@oss-tech.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Juri Lelli <juri.lelli@arm.com>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Palmer Dabbelt <palmer@sifive.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [RFT PATCH v1 2/4] dt-binding: cpu-topology: Move cpu-map to a common binding.
Date: Mon, 3 Dec 2018 09:40:21 -0800 [thread overview]
Message-ID: <e983d74f-9671-a119-63a4-dd4e12fe0f96@wdc.com> (raw)
In-Reply-To: <20181203173306.GF17883@e107155-lin>
On 12/3/18 9:33 AM, Sudeep Holla wrote:
> On Mon, Dec 03, 2018 at 09:23:42AM -0800, Atish Patra wrote:
>> On 12/3/18 8:55 AM, Sudeep Holla wrote:
>>> On Thu, Nov 29, 2018 at 03:28:18PM -0800, Atish Patra wrote:
>>>> cpu-map binding can be used to described cpu topology for both
>>>> RISC-V & ARM. It makes more sense to move the binding to document
>>>> to a common place.
>>>>
>>>> The relevant discussion can be found here.
>>>> https://lkml.org/lkml/2018/11/6/19
>>>>
>>>
>>> Looks good to me apart from a minor query below in the example.
>>>
>>> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>>>
>>>> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>>>> ---
>>>> .../{arm/topology.txt => cpu/cpu-topology.txt} | 81 ++++++++++++++++++----
>>>> 1 file changed, 67 insertions(+), 14 deletions(-)
>>>> rename Documentation/devicetree/bindings/{arm/topology.txt => cpu/cpu-topology.txt} (86%)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/topology.txt b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
>>>> similarity index 86%
>>>> rename from Documentation/devicetree/bindings/arm/topology.txt
>>>> rename to Documentation/devicetree/bindings/cpu/cpu-topology.txt
>>>> index 66848355..1de6fbce 100644
>>>> --- a/Documentation/devicetree/bindings/arm/topology.txt
>>>> +++ b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
>>>
>>> [...]
>>>
>>>> +Example 3: HiFive Unleashed (RISC-V 64 bit, 4 core system)
>>>> +
>>>> +cpus {
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> + compatible = "sifive,fu540g", "sifive,fu500";
>>>> + model = "sifive,hifive-unleashed-a00";
>>>> +
>>>> + ...
>>>> +
>>>> + cpu-map {
>>>> + cluster0 {
>>>> + core0 {
>>>> + cpu = <&L12>;
>>>> + };
>>>> + core1 {
>>>> + cpu = <&L15>;
>>>> + };
>>>> + core2 {
>>>> + cpu0 = <&L18>;
>>>> + };
>>>> + core3 {
>>>> + cpu0 = <&L21>;
>>>> + };
>>>> + };
>>>> + };
>>>> +
>>>> + L12: cpu@1 {
>>>> + device_type = "cpu";
>>>> + compatible = "sifive,rocket0", "riscv";
>>>> + reg = <0x1>;
>>>> + }
>>>> +
>>>> + L15: cpu@2 {
>>>> + device_type = "cpu";
>>>> + compatible = "sifive,rocket0", "riscv";
>>>> + reg = <0x2>;
>>>> + }
>>>> + L18: cpu@3 {
>>>> + device_type = "cpu";
>>>> + compatible = "sifive,rocket0", "riscv";
>>>> + reg = <0x3>;
>>>> + }
>>>> + L21: cpu@4 {
>>>> + device_type = "cpu";
>>>> + compatible = "sifive,rocket0", "riscv";
>>>> + reg = <0x4>;
>>>> + }
>>>> +};
>>>
>>> The labels for the CPUs drew my attention. Is it intentionally random
>>> (or even specific) or just chosen to show anything can be used as labels ?
>>
>> SiFive generates the device tree from RTL directly. So I am not sure if they
>> assign random numbers or a particular algorithm chooses the label. I tried
>> to put the exact ones that is available publicly.
>>
>> https://github.com/riscv/riscv-device-tree-doc/blob/master/examples/sifive-hifive_unleashed-microsemi.dts
>
> Cool, love that. So you don't have the problem I was trying to explain.
> But I still see the possibility of some other RISC-V vendor copy-pasting
> from here ;). Anyways it's left to you.
>
I am fine with either way. I hoped other vendors won't blindly copy as
this example was specific to HiFive Unleashed board. But I get your
point. As this DT entry is a generic architecture entry, we should have
generic examples instead of platform specific examples.
I will change it to a generic one.
Regards,
Atish
> --
> Regards,
> Sudeep
>
next prev parent reply other threads:[~2018-12-03 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:28 [RFT PATCH v1 0/4] Unify CPU topology across ARM64 & RISC-V Atish Patra
2018-11-29 23:28 ` [RFT PATCH v1 1/4] Documentation: DT: arm: add support for sockets defining package boundaries Atish Patra
2018-12-03 16:46 ` Sudeep Holla
2018-12-12 2:18 ` Rob Herring
2018-11-29 23:28 ` [RFT PATCH v1 2/4] dt-binding: cpu-topology: Move cpu-map to a common binding Atish Patra
2018-12-03 16:55 ` Sudeep Holla
2018-12-03 17:23 ` Atish Patra
2018-12-03 17:33 ` Sudeep Holla
2018-12-03 17:40 ` Atish Patra [this message]
2018-12-12 2:21 ` Rob Herring
2018-12-12 2:31 ` Rob Herring
2018-12-12 18:23 ` Atish Patra
2018-11-29 23:28 ` [RFT PATCH v1 3/4] cpu-topology: Move cpu topology code to common code Atish Patra
2018-12-03 16:58 ` Will Deacon
2018-12-03 17:12 ` Sudeep Holla
2018-12-04 9:50 ` Juri Lelli
2018-12-03 17:16 ` Sudeep Holla
2018-12-03 17:31 ` Atish Patra
2018-11-29 23:28 ` [RFT PATCH v1 4/4] RISC-V: Parse cpu topology during boot Atish Patra
2018-12-03 16:59 ` Sudeep Holla
2018-12-05 17:53 ` [RFT PATCH v1 0/4] Unify CPU topology across ARM64 & RISC-V Jeffrey Hugo
2018-12-11 0:26 ` Atish Patra
2018-12-07 13:45 ` Morten Rasmussen
2018-12-07 15:04 ` Sudeep Holla
2018-12-11 0:11 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e983d74f-9671-a119-63a4-dd4e12fe0f96@wdc.com \
--to=atish.patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitriy@oss-tech.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=palmer@sifive.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).