From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>,
"Eduardo Valentin" <eduval@amazon.com>
Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush
Date: Thu, 9 Nov 2017 11:48:35 +0100 [thread overview]
Message-ID: <e985d61a-18ef-6dce-e058-c45538ffcdff@redhat.com> (raw)
In-Reply-To: <1510192934-5369-3-git-send-email-wanpeng.li@hotmail.com>
On 09/11/2017 03:02, Wanpeng Li wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> Remote flushing api's does a busy wait which is fine in bare-metal
> scenario. But with-in the guest, the vcpus might have been pre-empted
> or blocked. In this scenario, the initator vcpu would end up
> busy-waiting for a long amount of time.
>
> This patch set implements para-virt flush tlbs making sure that it
> does not wait for vcpus that are sleeping. And all the sleeping vcpus
> flush the tlb on guest enter.
>
> The best result is achieved when we're overcommiting the host by running
> multiple vCPUs on each pCPU. In this case PV tlb flush avoids touching
> vCPUs which are not scheduled and avoid the wait on the main CPU.
>
> Test on a Haswell i7 desktop 4 cores (2HT), so 8 pCPUs, running ebizzy in
> one linux guest.
>
> ebizzy -M
> vanilla optimized boost
> 8 vCPUs 10152 10083 -0.68%
> 16 vCPUs 1224 4866 297.5%
> 24 vCPUs 1109 3871 249%
> 32 vCPUs 1025 3375 229.3%
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> arch/x86/include/uapi/asm/kvm_para.h | 1 +
> arch/x86/kernel/kvm.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h
> index ff23ce9..189e354 100644
> --- a/arch/x86/include/uapi/asm/kvm_para.h
> +++ b/arch/x86/include/uapi/asm/kvm_para.h
> @@ -52,6 +52,7 @@ struct kvm_steal_time {
>
> #define KVM_VCPU_NOT_PREEMPTED (0 << 0)
> #define KVM_VCPU_PREEMPTED (1 << 0)
> +#define KVM_VCPU_SHOULD_FLUSH (1 << 1)
>
> #define KVM_CLOCK_PAIRING_WALLCLOCK 0
> struct kvm_clock_pairing {
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 1b1b641..2e2f3ae 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -465,6 +465,33 @@ static void __init kvm_apf_trap_init(void)
> update_intr_gate(X86_TRAP_PF, async_page_fault);
> }
>
> +static void kvm_flush_tlb_others(const struct cpumask *cpumask,
> + const struct flush_tlb_info *info)
> +{
> + u8 state;
> + int cpu;
> + struct kvm_steal_time *src;
> + cpumask_t flushmask;
> +
> +
> + cpumask_copy(&flushmask, cpumask);
> + /*
> + * We have to call flush only on online vCPUs. And
> + * queue flush_on_enter for pre-empted vCPUs
> + */
> + for_each_cpu(cpu, cpumask) {
> + src = &per_cpu(steal_time, cpu);
> + state = src->preempted;
> + if ((state & KVM_VCPU_PREEMPTED)) {
> + if (cmpxchg(&src->preempted, state, state | 1 <<
> + KVM_VCPU_SHOULD_FLUSH))
> + cpumask_clear_cpu(cpu, &flushmask);
> + }
> + }
> +
> + native_flush_tlb_others(&flushmask, info);
> +}
> +
> void __init kvm_guest_init(void)
> {
> int i;
> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void)
> pv_time_ops.steal_clock = kvm_steal_clock;
> }
>
> + pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
This needs to be keyed on a new CPUID feature bit. Eduardo is also
adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when
PV_DEDICATED is set.
Paolo
> if (kvm_para_has_feature(KVM_FEATURE_PV_EOI))
> apic_set_eoi_write(kvm_guest_apic_eoi_write);
>
>
next prev parent reply other threads:[~2017-11-09 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 2:02 [PATCH RESEND 0/3] KVM: Paravirt remote TLB flush Wanpeng Li
2017-11-09 2:02 ` [PATCH RESEND 1/3] KVM: Add vCPU running/preempted state Wanpeng Li
2017-11-09 2:02 ` [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush Wanpeng Li
2017-11-09 10:48 ` Paolo Bonzini [this message]
2017-11-09 11:01 ` Wanpeng Li
2017-11-09 11:02 ` Paolo Bonzini
2017-11-09 11:08 ` Wanpeng Li
2017-11-09 15:11 ` Radim Krčmář
2017-11-09 2:02 ` [PATCH RESEND 3/3] KVM: Add flush_on_enter before guest enter Wanpeng Li
2017-11-09 10:54 ` Paolo Bonzini
2017-11-09 12:31 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e985d61a-18ef-6dce-e058-c45538ffcdff@redhat.com \
--to=pbonzini@redhat.com \
--cc=eduval@amazon.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).