From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>, linux-mips@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks
Date: Sun, 28 Jun 2020 11:23:12 +0800 [thread overview]
Message-ID: <e98e609b-1074-c57c-3b17-6fb635474762@loongson.cn> (raw)
In-Reply-To: <0e39761c-4673-d116-fc62-5573c2abae06@web.de>
On 06/24/2020 09:12 PM, Markus Elfring wrote:
>> There exists potential resource leaks in the error path, fix them.
> Would you like to reconsider this change description?
> https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a0b4@loongson.cn/
> https://lkml.org/lkml/2020/6/24/498
>
>
> …
>> +++ b/drivers/irqchip/irq-davinci-aintc.c
> …
>> @@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
>> irq_base + irq_off, 32);
>>
>> set_handle_irq(davinci_aintc_handle_irq);
>> +
>> +err_domain_remove:
> …
>
> Are you sure that you would to like to release the allocated system resources
> always in this function implementation?
>
> Otherwise, I suggest to add a return statement before the source code section
> for the desired exception handling.
Thank you! Sorry for the late reply.
I will add a return statement.
>
> Regards,
> Markus
next prev parent reply other threads:[~2020-06-28 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:12 [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks Markus Elfring
2020-06-28 3:23 ` Tiezhu Yang [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-24 7:29 [PATCH v3 00/14] irqchip: " Tiezhu Yang
2020-06-24 7:29 ` [PATCH v3 04/14] irqchip/davinci-aintc: " Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98e609b-1074-c57c-3b17-6fb635474762@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=Markus.Elfring@web.de \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).