From: Matthias Brugger <matthias.bgg@gmail.com>
To: Qii Wang <qii.wang@mediatek.com>, wsa@the-dreams.de
Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
robh@kernel.org, leilk.liu@mediatek.com,
xinping.qian@mediatek.com, linux-kernel@vger.kernel.org,
liguo.zhang@mediatek.com, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: i2c: Add Mediatek MT8183 i2c binding
Date: Wed, 20 Feb 2019 16:25:48 +0100 [thread overview]
Message-ID: <e9d544c8-576d-f52c-d805-90d695b7ed46@gmail.com> (raw)
In-Reply-To: <1550666030-30211-3-git-send-email-qii.wang@mediatek.com>
On 20/02/2019 13:33, Qii Wang wrote:
> Add MT8183 i2c binding to binding file. Compare to MT2712 i2c
> controller, MT8183 has different registers, offsets, and clock.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index ee4c324..da2fa60 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -12,14 +12,15 @@ Required properties:
> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for MediaTek MT7623
> "mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek MT7629
> "mediatek,mt8173-i2c": for MediaTek MT8173
> + "mediatek,mt8183-i2c": for MediaTek MT8183
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
> - clock-div: the fixed value for frequency divider of clock source in i2c
> module. Each IC may be different.
> - clocks: clock name from clock manager
> - - clock-names: Must include "main" and "dma", if enable have-pmic need include
> - "pmic" extra.
> + - clock-names: Must include "main" and "dma", "arb" is optional, if enable
> + have-pmic need include "pmic" extra.
You have to mention that the arb clock is only necessary for mt8183.
>
> Optional properties:
> - clock-frequency: Frequency in Hz of the bus when transfer, the default value
>
next prev parent reply other threads:[~2019-02-20 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 12:33 [PATCH v4 0/3] add i2c support for mt8183 Qii Wang
2019-02-20 12:33 ` [PATCH v4 1/3] i2c: mediatek: Add offsets array for new i2c registers Qii Wang
2019-02-20 14:31 ` Matthias Brugger
2019-02-20 12:33 ` [PATCH v4 2/3] dt-bindings: i2c: Add Mediatek MT8183 i2c binding Qii Wang
2019-02-20 15:25 ` Matthias Brugger [this message]
2019-02-21 13:32 ` Qii Wang
2019-02-21 14:22 ` Matthias Brugger
2019-02-20 12:33 ` [PATCH v4 3/3] i2c: mediatek: Add i2c support for MediaTek MT8183 Qii Wang
2019-02-20 14:41 ` Matthias Brugger
2019-02-21 13:31 ` Qii Wang
2019-03-07 3:09 ` Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9d544c8-576d-f52c-d805-90d695b7ed46@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=qii.wang@mediatek.com \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=xinping.qian@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).