From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10922C433DB for ; Mon, 15 Feb 2021 18:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE0D264E20 for ; Mon, 15 Feb 2021 18:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230416AbhBOScx (ORCPT ); Mon, 15 Feb 2021 13:32:53 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48453 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbhBOSct (ORCPT ); Mon, 15 Feb 2021 13:32:49 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 400C7F7F; Mon, 15 Feb 2021 13:31:43 -0500 (EST) Received: from imap22 ([10.202.2.72]) by compute3.internal (MEProxy); Mon, 15 Feb 2021 13:31:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=drnd.me; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=0qCRLx0h2AKsHxckh5wv5Va15TvWqZZ LVNedxRK01Us=; b=R4gkr88Bdqm/LpB+5hgG8cbkA91QotWhE/lNlW/qWr0ZwqU gYFKIY/mJqVxZYyXshAWiSXNUq4+jstIgovKJoetilLj1ArFTl4i7bELem67kaFN /X8VT5kW8bK9hOo1+e1Lo6fkL/Zsy+uu25i/gdaZv0AzyEAGSbJxxRzO2fl7Jf13 TZ3s7D4V4wIzUyEt75L/e9FMtQQNp7n+/L63Oca8cIj9dOjU2oI6s2ZJlTxW0zE+ 1j9dIBE713+vqSJfS1W+9y4dr40312ox/PZ0nwTHIX+ArB8PvBVvUJJwov0taiLI KPxqb2m9KhwGWlfiAW6DxfUHt5eIKf0c+5uJTCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0qCRLx 0h2AKsHxckh5wv5Va15TvWqZZLVNedxRK01Us=; b=kB8WCs9c9ZZsiGChHgJJb0 KvETPjR7lZmrfTYk0zIdOsx1PGYBKKmp9t1rnJt2Mzm+6A7hbkpCikJasezlldfl V1NoJRXqzDtupB9CfgdJ15cTXxWJkkSQXTZfYC00jipsyTgvB92yYRsFp3NH1+Wu Miq/tJcA7utmmk/yzq8XG2L48RyTtrlEqnWbjd4B/MkXVl3Tdr7rBm0OXNwQgElR SncPpjpuAH1JJ/M8k5eggKb/P6+rlHffYkDYTtLl8nPPGtLHRPr2xlmZ6vAaNgAB HlILqEPlbBmc8k7dlg+Q7DniaGx99/zQQASyWruj2dYMaS3m2FIaWPxd1N8JBQVg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrieekgddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdghihhl lhhirghmucffuhhrrghnugdfuceofihilhhlodhgihhtsegurhhnugdrmhgvqeenucggtf frrghtthgvrhhnpeevffdttddtvdehtdejueethedtheevkefftdelgfeluddtgfffueel vdfgudfhffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpeifihhllhdoghhithesughrnhgurdhmvg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 65D0762C005E; Mon, 15 Feb 2021 13:31:42 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a Mime-Version: 1.0 Message-Id: In-Reply-To: <20210215130334.GM2087@kadam> References: <20210213092014.29466-1-will+git@drnd.me> <20210215130334.GM2087@kadam> Date: Mon, 15 Feb 2021 19:30:29 +0100 From: "William Durand" To: "Dan Carpenter" Cc: "Greg Kroah-Hartman" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: fix typo in a function name Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sat, Feb 13, 2021 at 09:20:14AM +0000, William Durand wrote: > > Other function names use the verb 'query' so this function should > > probably use it too and that's what this patch is about. I didn't > > find any other occurrence and the code compiles. > > > > It's really just assumed that the code still compiles afterwards. > Sometimes, it's hard for me to right commit messages confidently because > I don't know if static checker bugs affect real life. But in this case > I really think the commit message could be written more confidently. > > Please write it like this: > "There is a typo here where it says "qurey" but "query" was intended." Thanks Dan, I'll update the commit message shortly and send a new patch. Will