From: Greg Ungerer <gerg@linux-m68k.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, peng.fan@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
Angelo Dureghello <angelo.dureghello@timesys.com>
Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
Date: Tue, 27 Oct 2020 09:53:59 +1000 [thread overview]
Message-ID: <e9dd314f-8bb4-f5f5-3dae-9bd4574ff20d@linux-m68k.org> (raw)
In-Reply-To: <20201023152842.GA5227@kozik-lap>
On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> The legacy platform device code has been removed under arch/arm/mach-imx,
>> so we no need id_table entry here.
>
> Cc: Greg, Geert, Angelo,
>
> Aren't you breaking Coldfire platforms?
Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.
Regards
Greg
> Best regards,
> Krzysztof
>
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> drivers/i2c/busses/i2c-imx.c | 14 --------------
>> 1 file changed, 14 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
>> index ba9d639223ec..7ea36a78abb0 100644
>> --- a/drivers/i2c/busses/i2c-imx.c
>> +++ b/drivers/i2c/busses/i2c-imx.c
>> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>>
>> };
>>
>> -static const struct platform_device_id imx_i2c_devtype[] = {
>> - {
>> - .name = "imx1-i2c",
>> - .driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
>> - }, {
next prev parent reply other threads:[~2020-10-27 0:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:18 [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code peng.fan
2020-10-23 8:18 ` [PATCH 2/2] i2c: imx: remove id_table entry peng.fan
2020-10-23 15:28 ` Krzysztof Kozlowski
2020-10-24 7:47 ` Peng Fan
2020-10-24 19:25 ` Krzysztof Kozlowski
2020-10-26 1:41 ` Peng Fan
2020-10-26 23:53 ` Greg Ungerer [this message]
2020-10-23 15:23 ` [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Krzysztof Kozlowski
2020-10-24 7:39 ` Peng Fan
2020-10-24 19:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9dd314f-8bb4-f5f5-3dae-9bd4574ff20d@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=angelo.dureghello@timesys.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).