From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>, Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] netfilter: conntrack: fix -Wformat
Date: Thu, 03 Dec 2020 08:45:34 -0800 [thread overview]
Message-ID: <e9edd473b8bfc576b8b274c64fd74d021bc4f4d0.camel@perches.com> (raw)
In-Reply-To: <844b0184-a74b-4d0a-8470-69d58323391a@redhat.com>
On Thu, 2020-12-03 at 06:39 -0800, Tom Rix wrote:
> I agree if it can be done in checkpatch it should.
> It is good to have multiple passes on cleaning.
true
> checkpatch is best at fixing new problems,
> clang-tidy-fix is best at fixing old problems.
checkpatch is a set of brainless regexes that operates on
incomplete information. It's not a real parser nor compiler.
It's really only useful as a way to avoid trivial style issues.
next prev parent reply other threads:[~2020-12-03 16:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 7:55 [PATCH] netfilter: conntrack: fix -Wformat Nick Desaulniers
2020-11-07 10:32 ` Joe Perches
2020-11-08 7:34 ` Lukas Bulwahn
2020-11-08 10:10 ` Joe Perches
2020-11-10 22:00 ` Nick Desaulniers
2020-11-10 22:04 ` Joe Perches
2020-11-10 22:06 ` Nick Desaulniers
2020-12-02 22:34 ` Nick Desaulniers
2020-12-03 0:46 ` Tom Rix
2020-12-03 7:26 ` Lukas Bulwahn
2020-12-03 13:43 ` Miguel Ojeda
2020-12-03 14:40 ` Lukas Bulwahn
2020-12-03 14:39 ` Tom Rix
2020-12-03 16:45 ` Joe Perches [this message]
2020-12-13 19:21 ` Tom Rix
2020-12-13 23:25 ` Joe Perches
2020-12-13 23:29 ` Tom Rix
2020-11-07 17:52 ` Jakub Kicinski
2020-11-09 15:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9edd473b8bfc576b8b274c64fd74d021bc4f4d0.camel@perches.com \
--to=joe@perches.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).