From: Quan Nguyen <quan@os.amperecomputing.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Thu Nguyen <thu@os.amperecomputing.com>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v7 5/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Mon, 21 Mar 2022 16:46:50 +0700 [thread overview]
Message-ID: <e9f92650-4f7c-260d-8aa2-92d1c84bf74a@os.amperecomputing.com> (raw)
In-Reply-To: <Yjg1nREijopyA+8A@kroah.com>
On 21/03/2022 15:21, Greg Kroah-Hartman wrote:
> On Mon, Mar 21, 2022 at 03:13:51PM +0700, Quan Nguyen wrote:
>> This commit adds driver support for accessing various information
>> reported by Ampere's SMpro co-processor such as Boot Progress and
>> other miscellaneous data.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>
> No Documentation/ABI/ entries for your sysfs file?
>
Thank you, Greg, for a very quick review.
I have put this file in other patch.
>> +static ssize_t boot_progress_show(struct device *dev, struct device_attribute *da, char *buf)
>> +{
>> + struct smpro_misc *misc = dev_get_drvdata(dev);
>> + u32 boot_progress;
>> + u8 current_stage;
>> + u8 boot_status;
>> + u8 boot_stage;
>> + u32 select;
>> + u32 reg_lo;
>> + u32 reg;
>> + int ret;
>> +
>> + /* Read current boot stage */
>> + ret = regmap_read(misc->regmap, BOOTSTAGE_CUR_STAGE, ®);
>> + if (ret)
>> + return ret;
>> +
>> + current_stage = reg & 0xff;
>> +
>> + /* Read the boot progress */
>> + ret = regmap_read(misc->regmap, BOOTSTAGE_SELECT, &select);
>> + if (ret)
>> + return ret;
>> +
>> + boot_stage = (select >> 8) & 0xff;
>> + boot_status = select & 0xff;
>> +
>> + if (boot_stage > current_stage)
>> + return -EINVAL;
>> +
>> + ret = regmap_read(misc->regmap, BOOTSTAGE_STATUS_LO, ®_lo);
>> + if (!ret)
>> + ret = regmap_read(misc->regmap, BOOTSTAGE_STATUS_HI, ®);
>> + if (ret)
>> + return ret;
>> +
>> + boot_progress = swab16(reg) << 16 | swab16(reg_lo);
>> +
>> + /* Tell firmware to provide next boot stage next time */
>> + if (boot_stage < current_stage) {
>> + ret = regmap_write(misc->regmap, BOOTSTAGE_SELECT, ((select & 0xff00) | 0x1));
>> + if (ret)
>> + return ret;
>> + }
>> +
>> + return snprintf(buf, PAGE_SIZE, "0x%02x 0x%02x 0x%08x\n",
>> + boot_stage, boot_status, boot_progress);
>
> sysfs_emit() please.
>
Thanks, Greg.
Will switch to sysfs_emit() in my next version.
> Also, this is 3 different things, put all of these in different sysfs
> files.
>
> thanks,
>
> greg k-h
Actually, no. It is single value of boot stage.
Let me explain:
The boot progress consists of three things together: boot_stage,
boot_status and boot_progress and they have no meaning if reported them
as three separate values:
+ boot_stage is to indicate the boot stage
+ boot_status is to report the result of that boot_stage: started,
complete or error.
+ boot_progress is to report more extra information for the stage other
than the boot_stage/boot_status.
There is more information in the Documentation/ABI/testing sysfs patch.
- Quan
next prev parent reply other threads:[~2022-03-21 9:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 8:13 [PATCH v7 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 1/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 2/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 3/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen
2022-03-21 14:24 ` kernel test robot
2022-03-21 8:13 ` [PATCH v7 4/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 5/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen
2022-03-21 8:21 ` Greg Kroah-Hartman
2022-03-21 9:46 ` Quan Nguyen [this message]
2022-03-21 10:02 ` Greg Kroah-Hartman
2022-03-25 7:14 ` Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 6/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 7/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen
2022-03-21 10:08 ` Krzysztof Kozlowski
2022-03-25 7:13 ` Quan Nguyen
2022-03-21 8:13 ` [PATCH v7 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen
2022-03-21 17:38 ` kernel test robot
2022-03-21 8:13 ` [PATCH v7 9/9] docs: ABI: testing: Document the Ampere Altra Family's SMpro sysfs interfaces Quan Nguyen
2022-03-21 8:23 ` Greg Kroah-Hartman
2022-03-21 9:46 ` Quan Nguyen
2022-03-21 10:03 ` Greg Kroah-Hartman
2022-03-25 7:14 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f92650-4f7c-260d-8aa2-92d1c84bf74a@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
--cc=thu@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).