From: Guenter Roeck <linux@roeck-us.net>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants
Date: Tue, 11 Dec 2018 06:28:10 -0800 [thread overview]
Message-ID: <ea1a6013-2738-a636-3835-6cc57becd6ec@roeck-us.net> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7021C50E52E@SW-EX-MBX02.diasemi.com>
On 12/11/18 3:47 AM, Steve Twiss wrote:
> Hi Guenter,
>
> On 10 December 2018 22:09, Guenter Roeck wrote:
>
>> Subject: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific
>> SENSOR[_DEVICE]_ATTR variants
>>
>> Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
>> to improve readbility, and to reduce the chance of inconsistencies.
>>
>> Also replace any remaining S_<PERMS> in the driver with octal values.
>>
>> The conversion was done automatically with coccinelle. The semantic patches
>> and the scripts used to generate this commit log are available at
>> https://github.com/groeck/coccinelle-patches/hwmon/.
>>
>> This patch does not introduce functional changes. It was verified by
>> compiling the old and new files and comparing text and data sizes.
>>
>> Cc: Support Opensource <support.opensource@diasemi.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> drivers/hwmon/da9052-hwmon.c | 105 ++++++++++++++++------------------------
>
> Thanks,
>
> I am assuming this previous patch [01/10] hwmon: Introduce SENSOR_DEVICE_ATTR_{RO,RW,WO} and variants
> from this set, https://patchwork.kernel.org/patch/9489915/ and,
> + #define SENSOR_DEVICE_ATTR_RO(_name, _func, _index) \
> + SENSOR_DEVICE_ATTR(_name, 0444, _func##_show, NULL, _index)
>
Yes, of course. Sorry, I should have mentioned it.
> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
Thanks!
Guenter
next prev parent reply other threads:[~2018-12-11 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1544479728-30077-1-git-send-email-linux@roeck-us.net>
[not found] ` <1544479728-30077-22-git-send-email-linux@roeck-us.net>
2018-12-11 11:47 ` [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants Steve Twiss
2018-12-11 14:28 ` Guenter Roeck [this message]
[not found] ` <1544479728-30077-23-git-send-email-linux@roeck-us.net>
2018-12-11 11:47 ` [PATCH 22/30] hwmon: (da9055-hwmon) " Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea1a6013-2738-a636-3835-6cc57becd6ec@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Support.Opensource@diasemi.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).