From: John Garry <john.garry@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
"Paul A . Clarke" <pc@us.ibm.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <eranian@google.com>
Subject: Re: [PATCH v3 1/2] perf test: Workload test of metric and metricgroups
Date: Fri, 24 Sep 2021 20:39:18 +0100 [thread overview]
Message-ID: <ea23f319-49df-5905-758e-478baf44bdc9@huawei.com> (raw)
In-Reply-To: <YU4iVcVc6uYAWft4@kernel.org>
On 24/09/2021 20:09, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 17, 2021 at 11:42:39AM -0700, Ian Rogers escreveu:
>> Test every metric and metricgroup with 'true' as a workload. For
>> metrics, check that we see the metric printed or get unsupported. If the
>> 'true' workload executes too quickly retry with 'perf bench internals
>> synthesize'.
>>
>> v3. Fix test condition (thanks to Paul A. Clarke<pc@us.ibm.com>). Add a
>> fallback case of a larger workload so that we don't ignore "<not
>> counted>".
>> v2. Switched the workload to something faster.
> Hi John, does your Reviewed-by stands for v3 too?
>
> - Arnaldo
>
Yeah,
Reviewed-by: John Garry <john.garry@huawei.com>
Thanks
next prev parent reply other threads:[~2021-09-24 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 18:42 [PATCH v3 1/2] perf test: Workload test of metric and metricgroups Ian Rogers
2021-09-17 18:42 ` [PATCH v3 2/2] perf test: Workload test of all PMUs Ian Rogers
2021-09-24 19:09 ` [PATCH v3 1/2] perf test: Workload test of metric and metricgroups Arnaldo Carvalho de Melo
2021-09-24 19:39 ` John Garry [this message]
2021-09-28 18:55 ` Arnaldo Carvalho de Melo
2022-01-12 12:24 ` John Garry
2022-01-12 13:34 ` Arnaldo Carvalho de Melo
2022-01-12 17:32 ` John Garry
2022-01-12 17:59 ` Arnaldo Carvalho de Melo
2022-01-12 18:00 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea23f319-49df-5905-758e-478baf44bdc9@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).