From: Joe Perches <joe@perches.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@kernel.org>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liu Ying <victor.liu@nxp.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal
Date: Wed, 24 Mar 2021 15:46:09 -0700 [thread overview]
Message-ID: <ea434f6d5a4a8cdd31ca3347c5830bdd857058bf.camel@perches.com> (raw)
In-Reply-To: <aa3b389e-d433-0243-41c7-9d0b6da24ed7@rasmusvillemoes.dk>
On Wed, 2021-03-24 at 23:36 +0100, Rasmus Villemoes wrote:
> On 24/03/2021 23.18, Joe Perches wrote:
> > There's no silly game here. %pe would either print a string or a value.
>
> A hashed value, that is, never the raw value.
There is value in printing the raw value.
As discussed, it can simplify the code.
The worry about exposing a ptr value is IMO overstated.
It's trivial to inspect the uses and _all_ %p<FOO> uses need inspection
and validation at acceptance anyway.
next prev parent reply other threads:[~2021-03-24 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 12:17 [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning Arnd Bergmann
2021-03-24 14:20 ` Joe Perches
2021-03-24 16:42 ` Arnd Bergmann
2021-03-24 16:52 ` Joe Perches
2021-03-24 17:20 ` [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal Joe Perches
2021-03-24 17:33 ` Rasmus Villemoes
2021-03-24 19:24 ` Joe Perches
2021-03-24 21:27 ` Rasmus Villemoes
2021-03-24 22:18 ` Joe Perches
2021-03-24 22:36 ` Rasmus Villemoes
2021-03-24 22:46 ` Joe Perches [this message]
2021-03-24 16:14 ` [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea434f6d5a4a8cdd31ca3347c5830bdd857058bf.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=m.felsch@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=senozhatsky@chromium.org \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).