From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbeEJUdh (ORCPT ); Thu, 10 May 2018 16:33:37 -0400 Received: from mga03.intel.com ([134.134.136.65]:31799 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbeEJUdf (ORCPT ); Thu, 10 May 2018 16:33:35 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,386,1520924400"; d="asc'?scan'208";a="198366247" Message-ID: Subject: Re: [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link() From: Jeff Kirsher Reply-To: jeffrey.t.kirsher@intel.com To: Bjorn Helgaas , Ganesh Goudar , Michael Chan , Ariel Elior Cc: linux-pci@vger.kernel.org, everest-linux-l2@cavium.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Gilboa , Tariq Toukan , Jacob Keller , Jakub Kicinski Date: Thu, 10 May 2018 13:34:47 -0700 In-Reply-To: <20180510163357.GB190385@bhelgaas-glaptop.roam.corp.google.com> References: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com> <152537764322.62474.552711932384023140.stgit@bhelgaas-glaptop.roam.corp.google.com> <20180510163357.GB190385@bhelgaas-glaptop.roam.corp.google.com> Organization: Intel Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-ezjtuMDbw9aM3nX0qUyk" X-Mailer: Evolution 3.28.1 (3.28.1-2.fc28) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-ezjtuMDbw9aM3nX0qUyk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > >=20 > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the narrowest link without > > considering the total bandwidth of the link. > >=20 > > For example, consider a path with these two links: > >=20 > > - 16.0 GT/s x1 link (16.0 * 10^9 * 128 / 130) * 1 / 8 =3D 1969 > > MB/s > > - 2.5 GT/s x16 link ( 2.5 * 10^9 * 8 / 10) * 16 / 8 =3D 4000 > > MB/s > >=20 > > The available bandwidth of the path is limited by the 16 GT/s link > > to about > > 1969 MB/s, but pcie_get_minimum_link() returned 2.5 GT/s x1, which > > corresponds to only 250 MB/s. > >=20 > > Callers should use pcie_print_link_status() instead, or > > pcie_bandwidth_available() if they need more detailed information. > >=20 > > Remove pcie_get_minimum_link() since there are no callers left. > >=20 > > Signed-off-by: Bjorn Helgaas >=20 > Hi Jeff, >=20 > I got your note that you applied this to dev-queue. I assume that > means you also applied the preceding patches that removed all the > users. I got a note about ixgbe, but not the others, so I'm just > double-checking. I did initially apply it, but realized that I would have to apply the earlier patches as well, which did not pertain to the Intel wired LAN drivers. So I have removed this patch from queue and will only be testing the ixgbe patch of the series, which Andrew has already tested and responded to. --=-ezjtuMDbw9aM3nX0qUyk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlr0rOcACgkQ5W/vlVpL 7c42xBAAlFSF0qz3Go3dVfEzbDD1YlmobU8AzSTOONIuP3aFmggcNMR0pX+uoHLb QdqhMeh6/I3wUUpMX+eV0wF39hj6WOMAHOJiORU8SLa0SFRGiLzXnzKHprdIDTiJ isdNzJ/EkrogVu5QsuOMYA5O3bCc37SfwSSoaTJJU4w7MS1UvUjfwT2ZWT1bqxoI cM1UKUF+FKVv6QvgUf1JuLqpFtauyfJTy8/EnqPMPtkodxrp8F7dpui+NXt1gUM1 WbwW25ZqRcCsvMEFAC7Jf0YrRgnkkn/KUrNqBzL3LdgEbmeVcdWnrVqWHXlUplYJ Qt/x5NQ1E0uh4B5A3CeUVuuUHaZI3MPK1/MffHR1ja4NyI19o2KEAGPgmrajOEcK TFrKFyYCZOHO9flhVOUzbA6vReaz5ELELNwlNiS//4Qazp/YI/2u03a8LHQuSal/ 2aUkA+qYfTNzTvkupp52kCnStE1qB2mwu/10cxUAg2tqtq9ZiOoNbjs/JuQw6NWJ QP8waunF2r7r9+5fn1+X3tpDzoL65uZXwLQP92pEX9xlVYQcOIx9wf9ZCF/zHAGo VtUbNCtGwJnp1EypI9/PiGmFKHwnsOjhqAg2+yAJxuKlIeDtnVZRE9c/OXR++6aI 1ROAd/ODYha5ssWy+0hygaaZNrEPaF7G/k5ARPne4Yzo5c2geiQ= =9ryB -----END PGP SIGNATURE----- --=-ezjtuMDbw9aM3nX0qUyk--