From: Sibi Sankar <quic_sibis@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<robh+dt@kernel.org>, <manivannan.sadhasivam@linaro.org>
Cc: <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<konrad.dybcio@somainline.org>, <amit.pundir@linaro.org>,
<regressions@leemhuis.info>, <sumit.semwal@linaro.org>,
<will@kernel.org>, <catalin.marinas@arm.com>,
<robin.murphy@arm.com>
Subject: Re: [PATCH 2/4] dt-bindings: remoteproc: qcom: sc7180: Update memory-region requirements
Date: Wed, 14 Dec 2022 15:55:41 +0530 [thread overview]
Message-ID: <ea4e9a35-5468-820a-9e28-9cdf129b77e5@quicinc.com> (raw)
In-Reply-To: <612c1019-11c0-38b6-e1d5-1a52f1456989@linaro.org>
On 12/14/22 01:11, Krzysztof Kozlowski wrote:
> On 13/12/2022 15:07, Sibi Sankar wrote:
>> Update the bindings to reflect the addition of the new modem metadata
>> carveout reference to the memory-region property.
>>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++-
>> .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>> index e4a7da8020f4..b1402bef0ebe 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>> @@ -95,6 +95,7 @@ properties:
>> items:
>> - description: MBA reserved region
>> - description: modem reserved region
>> + - description: metadata reserved region
>
> Which makes the third item now required, also for all out of tree DTS
> and other users of the bindings. Please write a bit more in commit msg
> why this is necessary (e.g. was it broken before?). I assume the driver
> does not break the ABI?
I'll pad the commit msg with some of the additional info from patch 4.
commit c44094eee32f "arm64: dma: Drop cache invalidation from
arch_dma_prep_coherent()" exposed a bug in the driver affecting SoCs
from msm8996 on wards. The application processor accessing the
dynamically allocated region after giving control to the modem results
in a XPU violation. The recommended fix was to use a no-map carveout
instead and memunmap before giving control to the modem. The future
kernels that are paired with an older dtbs would crash during modem
bootup since we would continue to use dma_alloc_attr. But all the other
combinations (old kernel/new dtb) will continue to work.
- Sibi
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-12-14 10:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 14:07 [PATCH 0/4] Fix XPU violation during modem metadata authentication Sibi Sankar
2022-12-13 14:07 ` [PATCH 1/4] arm64: dts: qcom: Introduce a carveout for modem metadata Sibi Sankar
2022-12-13 19:40 ` Krzysztof Kozlowski
2022-12-14 6:49 ` Sibi Sankar
2022-12-14 8:09 ` Krzysztof Kozlowski
2022-12-14 11:27 ` Krzysztof Kozlowski
2022-12-14 11:44 ` Sibi Sankar
2022-12-14 12:54 ` Krzysztof Kozlowski
2022-12-13 14:07 ` [PATCH 2/4] dt-bindings: remoteproc: qcom: sc7180: Update memory-region requirements Sibi Sankar
2022-12-13 19:41 ` Krzysztof Kozlowski
2022-12-14 10:25 ` Sibi Sankar [this message]
2022-12-14 11:30 ` Krzysztof Kozlowski
2022-12-14 11:56 ` Sibi Sankar
2022-12-13 14:07 ` [PATCH 3/4] dt-bindings: remoteproc: qcom: q6v5: Update memory region requirements Sibi Sankar
2022-12-13 14:07 ` [PATCH 4/4] remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem headers Sibi Sankar
2022-12-13 15:07 ` Robin Murphy
2022-12-13 15:57 ` Sibi Sankar
2022-12-13 16:07 ` Manivannan Sadhasivam
2022-12-14 12:49 ` Robin Murphy
2022-12-13 19:47 ` Krzysztof Kozlowski
2022-12-14 10:33 ` Sibi Sankar
2022-12-14 11:28 ` Krzysztof Kozlowski
2022-12-14 11:51 ` Sibi Sankar
2022-12-15 8:51 ` Krzysztof Kozlowski
2022-12-27 12:18 ` [PATCH 0/4] Fix XPU violation during modem metadata authentication Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea4e9a35-5468-820a-9e28-9cdf129b77e5@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=regressions@leemhuis.info \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).