From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757515AbcH2Oqk (ORCPT ); Mon, 29 Aug 2016 10:46:40 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45930 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757480AbcH2Oqi (ORCPT ); Mon, 29 Aug 2016 10:46:38 -0400 Subject: Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER To: Jean Delvare , Alexander Kapshuk References: <20160829120634.039204a6@endymion> <20160829121140.38c10554@endymion> Cc: linux-hwmon@vger.kernel.org, linux-kernel From: Guenter Roeck Message-ID: Date: Mon, 29 Aug 2016 07:46:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160829121140.38c10554@endymion> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2016 03:11 AM, Jean Delvare wrote: > On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: >> I'm trying to find when the bug was introduced. I have a hard time >> believing it went unnoticed for long. If it fixes your problem I'll >> send a clean patch. > > Broken by: > > commit 52929715634ad36782bd7018ab0bf59a6619c393 > Author: Guenter Roeck > Date: Sat Mar 30 14:00:08 2013 -0700 > > hwmon: (it87) Use is_visible for voltage sensors > Yes. Oops, I should know better. Thanks for picking this up so quickly. Guenter