linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Navid Emamdoost <navid.emamdoost@gmail.com>,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
	Kangjie Lu <kjlu@umn.edu>, Stephen McCamant <smccaman@umn.edu>,
	Forest Bond <forest@alittletooquiet.net>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Madhumitha Prabakaran <madhumithabiw@gmail.com>,
	Malcolm Priestley <tvboxspy@gmail.com>
Subject: Re: staging: vt6655: Fix memory leak in vt6655_probe
Date: Sun, 6 Oct 2019 07:39:30 +0200	[thread overview]
Message-ID: <ea5e4945-b48f-0955-ba52-071ef1bb0e57@web.de> (raw)
In-Reply-To: <20191005184035.GA2062613@kroah.com>

>>> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
>>> like other error handling cases. The call to device_free_info() is
>>> added.
>>
>> Please improve this change description.
>
> It is fine as-is, please do not confuse people.

Would you like to clarify a known guideline once more?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=43b815c6a8e7dbccb5b8bd9c4b099c24bc22d135#n151
“…
Describe your changes in imperative mood,
…”

Regards,
Markus

      reply	other threads:[~2019-10-06  5:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 20:03 [PATCH] staging: vt6655: Fix memory leak in vt6655_probe Navid Emamdoost
2019-10-05 16:30 ` Markus Elfring
2019-10-05 18:40   ` Greg Kroah-Hartman
2019-10-06  5:39     ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea5e4945-b48f-0955-ba52-071ef1bb0e57@web.de \
    --to=markus.elfring@web.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=emamd001@umn.edu \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhumithabiw@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=smccaman@umn.edu \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).