From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933856AbcKMLyu (ORCPT ); Sun, 13 Nov 2016 06:54:50 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:40197 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933584AbcKMLyt (ORCPT ); Sun, 13 Nov 2016 06:54:49 -0500 Subject: Re: [PATCH v4 01/26] staging: iio: tsl2583: check if chip is in a working state in in_illuminance_calibrate_store To: Brian Masney , linux-iio@vger.kernel.org References: <1478974781-1457-1-git-send-email-masneyb@onstation.org> <1478974781-1457-2-git-send-email-masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com From: Jonathan Cameron Message-ID: Date: Sun, 13 Nov 2016 11:54:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478974781-1457-2-git-send-email-masneyb@onstation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/16 18:19, Brian Masney wrote: > in_illuminance_calibrate_store() did not check to see if the chip is > in a working state. This patch adds the proper check. The return value > from taos_als_calibrate() was also not checked in this function, so the > proper check was also added while changes are being made here. > > Signed-off-by: Brian Masney Applied > --- > drivers/staging/iio/light/tsl2583.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c > index 1a7be12..de54e74 100644 > --- a/drivers/staging/iio/light/tsl2583.c > +++ b/drivers/staging/iio/light/tsl2583.c > @@ -501,16 +501,27 @@ static ssize_t in_illuminance_calibrate_store(struct device *dev, > { > struct iio_dev *indio_dev = dev_to_iio_dev(dev); > struct tsl2583_chip *chip = iio_priv(indio_dev); > - int value; > + int value, ret; > > if (kstrtoint(buf, 0, &value) || value != 1) > return -EINVAL; > > mutex_lock(&chip->als_mutex); > - taos_als_calibrate(indio_dev); > + > + if (chip->taos_chip_status != TSL258X_CHIP_WORKING) { > + ret = -EBUSY; > + goto done; > + } > + > + ret = taos_als_calibrate(indio_dev); > + if (ret < 0) > + goto done; > + > + ret = len; > +done: > mutex_unlock(&chip->als_mutex); > > - return len; > + return ret; > } > > static ssize_t in_illuminance_lux_table_show(struct device *dev, >