From: Tim Chen <tim.c.chen@linux.intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Luck@alison-desk.jf.intel.com, Tony <tony.luck@intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
David Rientjes <rientjes@google.com>,
Igor Mammedov <imammedo@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
brice.goglin@gmail.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC
Date: Thu, 22 Mar 2018 17:42:41 -0700 [thread overview]
Message-ID: <ea881957-db28-97f9-a923-a43e010d9e1b@linux.intel.com> (raw)
In-Reply-To: <20180322204922.GA2337@alison-desk.jf.intel.com>
On 03/22/2018 01:49 PM, Alison Schofield wrote:
>
> + */
> + if (!topology_same_node(c, o) &&
> + (c->x86_vendor == X86_VENDOR_INTEL &&
> + c->x86_model == INTEL_FAM6_SKYLAKE_X)) {
> + /* Use NUMA instead of coregroups for scheduling: */
> + x86_has_numa_in_package = true;
x86_has_numa_in_package will only be set true for SKYLAKE in the above?
This boolean probably should be set for (!topology_same_node(c, o) && match_die(c, o)) and not
dependent on cpu family. Only the return value should depend on cpu family.
Tim
> +
> + /*
> + * Return value doesn't actually matter because we
> + * are throwing away coregroups for scheduling anyway.
> + * Return false to bypass topology broken bug messages
> + * and fixups in sched_domain().
> + */
> + return false;
> + }
> +
> + return topology_sane(c, o, "llc");
> }
>
> /*
> @@ -454,12 +492,6 @@ static struct sched_domain_topology_level x86_topology[] = {
> { NULL, },
> };
>
> -/*
> - * Set if a package/die has multiple NUMA nodes inside.
> - * AMD Magny-Cours and Intel Cluster-on-Die have this.
> - */
> -static bool x86_has_numa_in_package;
> -
> void set_cpu_sibling_map(int cpu)
> {
> bool has_smt = smp_num_siblings > 1;
>
next prev parent reply other threads:[~2018-03-23 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 20:49 [PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC Alison Schofield
2018-03-22 23:20 ` Peter Zijlstra
2018-03-22 23:55 ` Dave Hansen
2018-03-22 23:30 ` Luck, Tony
2018-03-26 22:19 ` Alison Schofield
2018-03-26 22:45 ` Luck, Tony
2018-03-23 0:42 ` Tim Chen [this message]
2018-03-24 0:17 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea881957-db28-97f9-a923-a43e010d9e1b@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=Luck@alison-desk.jf.intel.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=brice.goglin@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).