From: houlong wei <houlong.wei@mediatek.com> To: Eizan Miyamoto <eizan@chromium.org> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "wenst@chromium.org" <wenst@chromium.org>, "Yong Wu (吴勇)" <Yong.Wu@mediatek.com>, "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>, "Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, "Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, houlong.wei@mediatek.com Subject: Re: [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Date: Wed, 18 Aug 2021 23:34:32 +0800 [thread overview] Message-ID: <ea8c8373fbf6a9895276f098cfa2cf3f7761a4b5.camel@mediatek.com> (raw) In-Reply-To: <CAOak1e-oyzxbvHimMReQpZCAPyCtAsaGixjwmoa0EzMjqaUxVg@mail.gmail.com> Hi Eizan, Firstly, about how to determine the master mdp driver, we also can judge the component type. The component type can be gotten by calling of_device_get_match_data(dev). If the component is MTK_MDP_RDMA, it is the master driver. No matter it is mdp_rdma0 or mdp_rdma1. Secondly, about supporting the multiple MDP master device nodes, you can try my advice in my previous comment after the completion of this series of patches. Thanks a lot. Regards, Houlong On Wed, 2021-08-18 at 15:43 +0800, Eizan Miyamoto wrote: > Hi Houlong, > > On Mon, Aug 16, 2021 at 1:00 PM houlong wei <houlong.wei@mediatek.com > > wrote: > > Hi Eizan, > > > > "mdp-rdma0" may be not the only one master device node. In fact, > > there > > are 2 "mdp-rdma" in mt8173. You can see "mdp_rdma1" via below link. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.13.11#n1016 > > If we add "mediatek,mt8173-mdp" to "mdp_rdma1" like below, we will > > have > > one more V4L2 video devie node. > > > > mdp_rdma1: rdma@14002000 { > > compatible = "mediatek,mt8173-mdp-rdma", > > "mediatek,mt8173-mdp"; > > ... > > } > > > > We should consider the case that there are more than one "MDP_RDMA" > > components. > > Would it be okay with you if we added support for multiple MDP master > device nodes in follow-up changes? My rationale is this: > - As far as I can tell, the mediatek integration with V4L2 currently > only handles a single MDP master device node. It's not clear to me > the > scope of changes that will be needed to make things work properly > with > multiple nodes. > - The patch series makes video decode work (admittedly, in light of > your comments not optimally) upstream, which is better than not > landing these changes at all. > > I'd like to say that I'm very open to (and excited about) discussing > further work to support multiple MDP master nodes, perhaps we can > work together on this so I can understand what needs to be done. > > Please let me know your thoughts, > > Eizan
next prev parent reply other threads:[~2021-08-18 15:34 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-02 12:12 [PATCH v6 0/9] Refactor MTK MDP driver into core/components Eizan Miyamoto 2021-08-02 12:12 ` [PATCH v6 1/9] mtk-mdp: propagate errors from clock_on Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-05 6:06 ` Dafna Hirschfeld 2021-08-09 3:23 ` Eizan Miyamoto 2021-08-09 7:42 ` Dafna Hirschfeld 2021-08-16 0:46 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 2/9] mtk-mdp: add driver to probe mdp components Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-05 6:40 ` Dafna Hirschfeld 2021-08-09 3:23 ` Eizan Miyamoto 2021-08-09 7:53 ` Dafna Hirschfeld 2021-08-11 11:15 ` Eizan Miyamoto 2021-08-16 1:05 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver Eizan Miyamoto 2021-08-03 10:26 ` Enric Balletbo Serra 2021-08-16 1:07 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 4/9] media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:10 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 5/9] mtk-mdp: make mdp driver to be loadable by platform_device_register*() Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:15 ` houlong wei 2021-08-16 3:37 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 6/9] soc: mediatek: mmsys: instantiate mdp virtual device from mmsys Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-16 1:18 ` houlong wei 2021-08-02 12:12 ` [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-03 11:46 ` Eizan Miyamoto 2021-08-16 3:00 ` houlong wei 2021-08-16 4:52 ` houlong wei 2021-08-18 7:50 ` Eizan Miyamoto 2021-08-18 15:42 ` houlong wei 2021-08-18 7:43 ` Eizan Miyamoto 2021-08-18 15:34 ` houlong wei [this message] 2021-08-02 12:12 ` [PATCH v6 8/9] dts: mtk-mdp: remove mediatek,vpu property from primary MDP device Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-02 12:12 ` [PATCH v6 9/9] dt-bindings: mediatek: remove vpu requirement from mtk-mdp Eizan Miyamoto 2021-08-03 10:27 ` Enric Balletbo Serra 2021-08-06 21:47 ` Rob Herring 2021-08-03 10:29 ` [PATCH v6 0/9] Refactor MTK MDP driver into core/components Enric Balletbo Serra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ea8c8373fbf6a9895276f098cfa2cf3f7761a4b5.camel@mediatek.com \ --to=houlong.wei@mediatek.com \ --cc=Andrew-CT.Chen@mediatek.com \ --cc=Minghsiu.Tsai@mediatek.com \ --cc=Yong.Wu@mediatek.com \ --cc=chunkuang.hu@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=eizan@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=wenst@chromium.org \ --subject='Re: [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).