From: "Jan Kundrát" <jan.kundrat@cesnet.cz>
To: Peter Vernia <peter.vernia@gmail.com>
Cc: <linus.walleij@linaro.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<poeschel@lemonage.de>
Subject: Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example
Date: Thu, 29 Aug 2019 16:52:24 +0200 [thread overview]
Message-ID: <eaa0f631-bf71-4ca9-b3ff-06d5d43cc58d@cesnet.cz> (raw)
In-Reply-To: <20190828195609.4176-1-peter.vernia@gmail.com>
On středa 28. srpna 2019 21:56:09 CEST, Peter Vernia wrote:
> The device-tree properties documentation-file specifies the property
> "microchip,spi-present-mask" as required for MCP23SXX chips. However,
> the device-tree-source example below it uses only "spi-present-mask".
> Without "microchip," on the front, the driver will print "missing
> spi-present-mask" when it initializes.
>
> Update the device-tree example with the correct property-name.
>
> Signed-off-by: Peter Vernia <peter.vernia@gmail.com>
Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> index 625a22e2f211..8b94aa8f5971 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> @@ -82,7 +82,7 @@ gpiom1: gpio@0 {
> compatible = "microchip,mcp23s17";
> gpio-controller;
> #gpio-cells = <2>;
> - spi-present-mask = <0x01>;
> + microchip,spi-present-mask = <0x01>;
> reg = <0>;
> spi-max-frequency = <1000000>;
> };
next prev parent reply other threads:[~2019-08-29 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 19:56 [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example Peter Vernia
2019-08-29 14:52 ` Jan Kundrát [this message]
2019-09-02 14:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa0f631-bf71-4ca9-b3ff-06d5d43cc58d@cesnet.cz \
--to=jan.kundrat@cesnet.cz \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.vernia@gmail.com \
--cc=poeschel@lemonage.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).