From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34486C43217 for ; Wed, 2 Nov 2022 08:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbiKBIVb (ORCPT ); Wed, 2 Nov 2022 04:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbiKBIVX (ORCPT ); Wed, 2 Nov 2022 04:21:23 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519FA23EAA for ; Wed, 2 Nov 2022 01:21:22 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id z14so23332894wrn.7 for ; Wed, 02 Nov 2022 01:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind.be; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YHCz1IQKO8CdYIXmRoFPXUYt9Y4HACcIA9wrhRlMDyI=; b=S0umXvvU6kMFaRahNQ1wf+3Kc66JPFwARDt4Xr7L0gocgoW+JI8bnpuoBiYOxVMOYK v2TeAURtVvN9lxSI2A7f4wPibmsLKJzlMQJLqd2x5JoNfyDG76WkxrRk3qagt2zeJ/1t PZnQkYZBpvMlxEdI0qguy8bLgiEUtw68+5D2WnakQfR131hYEEt6/DK5zxXcdOflYcLM dyBW2TcYkU8ZrWpineg/5wkuJkRcDwgWpvgEI3kJLUWAg3sT14/ZIOma5j612ZLB4dD9 CGf3B7YvnCifdFHtRh7Lrbcjp/dThznL7fyzXPLSgInHUr/ai/8riLyAEMDb2Q313p4f lyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YHCz1IQKO8CdYIXmRoFPXUYt9Y4HACcIA9wrhRlMDyI=; b=1dI/sxWRKbqH8mS/BmKn1bH7BNyhUUWomz/tnWkToU79pjxfUghRenNJAVn2KLG26g syO7CGOn6411pS7Fs1qnNnUfI3UE4XkYwx83222KptaMBYX6sFbqc7VIt2u9tPVhGJW2 WsMd5hsgkYCJ4muHRcN7cEefuzlUjkujU81TpjWtD/Sch1YaN0JJrPoe2C0B8epf0sLw eHrmLfbxiBZFZMh/EZshTxeSvVkT9pxmWoNor+ApI/aP5Wf2H98y0vv//bJGjsM12Ndx jonoQQOuSG3imKg+TCUACg3x76TCU4//A9qfL7AU89wb0Dc+6+dRHlr/rHxN+qmy3Vr+ RXfg== X-Gm-Message-State: ACrzQf2YKNlXPh/9CRUeyPyI+x0TvcOJYHY/0mK70IYT1CDeW8GbH1k0 QIrlwSgSRX4mAGIpDa3eCXw7GmsyCQoVMNs0 X-Google-Smtp-Source: AMsMyM5E/G3e51Qa7DpAGCsd5dZQoxdLgRYPiSwc1BpQBtksScg6LmysSYVuuj+70B/6cQ/FLYuUZg== X-Received: by 2002:adf:bd81:0:b0:236:dc6d:44a0 with SMTP id l1-20020adfbd81000000b00236dc6d44a0mr7069715wrh.175.1667377280861; Wed, 02 Nov 2022 01:21:20 -0700 (PDT) Received: from [192.168.2.9] (78-22-137-109.access.telenet.be. [78.22.137.109]) by smtp.gmail.com with ESMTPSA id w12-20020a05600c474c00b003b4a699ce8esm1303596wmo.6.2022.11.02.01.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 01:21:20 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 09:21:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] leds: lp5523: fix out-of-bounds bug in lp5523_selftest() Content-Language: en-US To: Pavel Machek Cc: Arne Staessen , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221028105643.45300-1-maarten.zanders@mind.be> <20221028153457.GA14936@duo.ucw.cz> From: Maarten Zanders In-Reply-To: <20221028153457.GA14936@duo.ucw.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On 10/28/22 17:34, Pavel Machek wrote: > I wonder, should we do these kind of actions on attribute _read_? I'd > preffer some kind of write action to trigger this. > Yes I agree that doing these kind of things on a file read feels somehow strange. Strictly speaking, I guess you would implement an IOCTL to initiate the action and then perform a read to get the result. But that would needlessly complicate things on both ends? I'll keep it in mind and when I encounter similar interfaces in other drivers get back to this if needed.