From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout
Date: Mon, 24 Feb 2020 08:31:17 -0800 [thread overview]
Message-ID: <eac16b4c-8920-78a0-6ca5-dd72cf83888d@infradead.org> (raw)
In-Reply-To: <20200224112537.14483-1-geert@linux-m68k.org>
On 2/24/20 3:25 AM, Geert Uytterhoeven wrote:
> On i386 randconfig:
>
> sound/soc/codecs/wm9705.o: In function `wm9705_soc_resume':
> wm9705.c:(.text+0x128): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9712.o: In function `wm9712_soc_resume':
> wm9712.c:(.text+0x2d1): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9713.o: In function `wm9713_soc_resume':
> wm9713.c:(.text+0x820): undefined reference to `snd_ac97_reset'
>
> Fix this by adding the missing dependencies on SND_SOC_AC97_BUS.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> Before commit ea00d95200d02ece ("ASoC: Use imply for
> SND_SOC_ALL_CODECS"), SND_SOC_ALL_CODECS used:
>
> select SND_SOC_WM9705 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
> select SND_SOC_WM9712 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
> select SND_SOC_WM9713 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
>
> but SND_SOC_AC97_BUS_NEW never existed in upstream.
> Should there be another dependency>
>
> See also "non-existent SND_SOC_AC97_BUS_NEW (was: Re: [PATCH v9] ASoC:
> pxa: switch to new ac97 bus support)"
> http://lore.kernel.org/r/CAMuHMdU3uxfBwKd8SkOtZSDV5Ai3CKc3CWRhDy0Cz94T1Hn0iA@mail.gmail.com
> ---
> sound/soc/codecs/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 9e9d54e4576ce5ba..a7e89567edbe8b47 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -1610,16 +1610,19 @@ config SND_SOC_WM9090
>
> config SND_SOC_WM9705
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
> config SND_SOC_WM9712
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
> config SND_SOC_WM9713
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
>
--
~Randy
next prev parent reply other threads:[~2020-02-24 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 11:25 [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout Geert Uytterhoeven
2020-02-24 13:41 ` Applied "ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout" to the asoc tree Mark Brown
2020-02-24 16:31 ` Randy Dunlap [this message]
2020-03-03 14:34 ` [PATCH] ASoC: Fix SND_SOC_ALL_CODECS imply ac97 fallout Guenter Roeck
2020-03-03 14:56 ` Geert Uytterhoeven
2020-03-03 16:14 ` Guenter Roeck
2020-03-04 23:14 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac16b4c-8920-78a0-6ca5-dd72cf83888d@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).