From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Nathan Chancellor <natechancellor@gmail.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map
Date: Thu, 31 Jan 2019 10:53:45 +0000 [thread overview]
Message-ID: <eac1b134-8d9e-21d4-d749-b40b98348eff@linaro.org> (raw)
In-Reply-To: <20190129214847.6341-1-natechancellor@gmail.com>
Thanks for the patch!
On 29/01/2019 21:48, Nathan Chancellor wrote:
> Clang warns:
>
> sound/soc/codecs/wcd9335.c:2004:11: warning: address of array
> 'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (wcd->rx_chs) {
> ~~ ~~~~~^~~~~~
> sound/soc/codecs/wcd9335.c:2012:11: warning: address of array
> 'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (wcd->tx_chs) {
> ~~ ~~~~~^~~~~~
> 2 warnings generated.
>
> Fixes: 20aedafdf492 ("ASoC: wcd9335: add support to wcd9335 codec")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
prev parent reply other threads:[~2019-01-31 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 21:48 [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel_map Nathan Chancellor
2019-01-31 10:53 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac1b134-8d9e-21d4-d749-b40b98348eff@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).