From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 274D2C433DB
	for <linux-kernel@archiver.kernel.org>; Wed, 17 Mar 2021 16:27:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id D572364F40
	for <linux-kernel@archiver.kernel.org>; Wed, 17 Mar 2021 16:27:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232476AbhCQQ0h (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 17 Mar 2021 12:26:37 -0400
Received: from smtprelay0212.hostedemail.com ([216.40.44.212]:46016 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S232006AbhCQQZ5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 Mar 2021 12:25:57 -0400
Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
        by smtpgrave02.hostedemail.com (Postfix) with ESMTP id C4BE018091592
        for <linux-kernel@vger.kernel.org>; Wed, 17 Mar 2021 14:59:03 +0000 (UTC)
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay08.hostedemail.com (Postfix) with ESMTP id D3071182CF668;
        Wed, 17 Mar 2021 14:58:02 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: top41_5206c062773f
X-Filterd-Recvd-Size: 1942
Received: from [192.168.1.159] (unknown [47.151.137.21])
        (Authenticated sender: joe@perches.com)
        by omf04.hostedemail.com (Postfix) with ESMTPA;
        Wed, 17 Mar 2021 14:58:00 +0000 (UTC)
Message-ID: <eae7016a8cd8f426987dd5c4a2a56c4ec6d28a6e.camel@perches.com>
Subject: Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to
 sysfs_emit_at
From:   Joe Perches <joe@perches.com>
To:     Qi Liu <liuqi115@huawei.com>, john.garry@huawei.com,
        zhangshaokun@hisilicon.com, will@kernel.org, mark.rutland@arm.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linuxarm@openeuler.org
Date:   Wed, 17 Mar 2021 07:57:59 -0700
In-Reply-To: <1615974111-45601-3-git-send-email-liuqi115@huawei.com>
References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com>
         <1615974111-45601-3-git-send-email-liuqi115@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2021-03-17 at 17:41 +0800, Qi Liu wrote:
> Use the generic sysfs_emit_at() function take place of scnprintf()
[]
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
[]
> @@ -328,41 +328,37 @@ static ssize_t arm_ccn_pmu_event_show(struct device *dev,
>  			struct arm_ccn_pmu_event, attr);
>  	ssize_t res;
>  
> 
> -	res = scnprintf(buf, PAGE_SIZE, "type=0x%x", event->type);
> +	res = sysfs_emit(buf, "type=0x%x", event->type);
>  	if (event->event)
> -		res += scnprintf(buf + res, PAGE_SIZE - res, ",event=0x%x",
> +		res += sysfs_emit_at(buf + res, res, ",event=0x%x",
>  				event->event);

sysfs_emit_at should always use buf, not buf + offset.
res should be int and is the offset from buf for the output

so the form should be similar to

	int len;

	len = sysfs_emit(buf, "type=0x%x", event->type);
	if (event->event) {
		len += sysfs_emit_at(buf, len, ",event=0x%x", event->event);

		etc...