linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
@ 2019-07-09 17:28 Nishka Dasgupta
  2019-07-31  8:31 ` Michal Simek
  0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2019-07-09 17:28 UTC (permalink / raw)
  To: jassisinghbrar, michal.simek, linux-kernel, linux-arm-kernel
  Cc: Nishka Dasgupta

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a goto from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
goto.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 86887c9a349a..bd80d4c10ec2 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 		if (ret) {
 			dev_err(dev, "failed to probe subdev.\n");
 			ret = -EINVAL;
+			of_node_put(nc);
 			goto free_mbox_dev;
 		}
 		mbox++;
-- 
2.19.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
  2019-07-09 17:28 [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto Nishka Dasgupta
@ 2019-07-31  8:31 ` Michal Simek
  2019-07-31 13:06   ` Nishka Dasgupta
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2019-07-31  8:31 UTC (permalink / raw)
  To: Nishka Dasgupta, jassisinghbrar, michal.simek, linux-kernel,
	linux-arm-kernel

On 09. 07. 19 19:28, Nishka Dasgupta wrote:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a goto from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> goto.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
>  drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 86887c9a349a..bd80d4c10ec2 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>  		if (ret) {
>  			dev_err(dev, "failed to probe subdev.\n");
>  			ret = -EINVAL;
> +			of_node_put(nc);
>  			goto free_mbox_dev;
>  		}
>  		mbox++;
> 

Patch is good but when you are saying that this was found by Coccinelle
then it should be added as script to kernel to detect it.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
  2019-07-31  8:31 ` Michal Simek
@ 2019-07-31 13:06   ` Nishka Dasgupta
  2019-07-31 14:21     ` Michal Simek
  0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2019-07-31 13:06 UTC (permalink / raw)
  To: Michal Simek, jassisinghbrar, linux-kernel, linux-arm-kernel

On 31/07/19 2:01 PM, Michal Simek wrote:
> On 09. 07. 19 19:28, Nishka Dasgupta wrote:
>> Each iteration of for_each_available_child_of_node puts the previous
>> node, but in the case of a goto from the middle of the loop, there is
>> no put, thus causing a memory leak. Hence add an of_node_put before the
>> goto.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>>   drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> index 86887c9a349a..bd80d4c10ec2 100644
>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>>   		if (ret) {
>>   			dev_err(dev, "failed to probe subdev.\n");
>>   			ret = -EINVAL;
>> +			of_node_put(nc);
>>   			goto free_mbox_dev;
>>   		}
>>   		mbox++;
>>
> 
> Patch is good but when you are saying that this was found by Coccinelle
> then it should be added as script to kernel to detect it.

This particular patch was suggested by a script I did not write myself; 
someone else wrote it and sent it to me. How should I proceed in this case?

Thanking you,
Nishka

> Thanks,
> Michal
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
  2019-07-31 13:06   ` Nishka Dasgupta
@ 2019-07-31 14:21     ` Michal Simek
  2019-08-02  4:59       ` Nishka Dasgupta
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2019-07-31 14:21 UTC (permalink / raw)
  To: Nishka Dasgupta, Michal Simek, jassisinghbrar, linux-kernel,
	linux-arm-kernel

On 31. 07. 19 15:06, Nishka Dasgupta wrote:
> On 31/07/19 2:01 PM, Michal Simek wrote:
>> On 09. 07. 19 19:28, Nishka Dasgupta wrote:
>>> Each iteration of for_each_available_child_of_node puts the previous
>>> node, but in the case of a goto from the middle of the loop, there is
>>> no put, thus causing a memory leak. Hence add an of_node_put before the
>>> goto.
>>> Issue found with Coccinelle.
>>>
>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>>> ---
>>>   drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>> b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>> index 86887c9a349a..bd80d4c10ec2 100644
>>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct
>>> platform_device *pdev)
>>>           if (ret) {
>>>               dev_err(dev, "failed to probe subdev.\n");
>>>               ret = -EINVAL;
>>> +            of_node_put(nc);
>>>               goto free_mbox_dev;
>>>           }
>>>           mbox++;
>>>
>>
>> Patch is good but when you are saying that this was found by Coccinelle
>> then it should be added as script to kernel to detect it.
> 
> This particular patch was suggested by a script I did not write myself;
> someone else wrote it and sent it to me. How should I proceed in this case?

You can ask him to submit it to kernel.
Or you can take it, keep his authorship and send it to:

./scripts/get_maintainer.pl -f scripts/coccinelle/
Julia Lawall <Julia.Lawall@lip6.fr> (supporter:COCCINELLE/Semantic
Patches (SmPL))
Gilles Muller <Gilles.Muller@lip6.fr> (supporter:COCCINELLE/Semantic
Patches (SmPL))
Nicolas Palix <nicolas.palix@imag.fr> (supporter:COCCINELLE/Semantic
Patches (SmPL))
Michal Marek <michal.lkml@markovi.net> (supporter:COCCINELLE/Semantic
Patches (SmPL))
cocci@systeme.lip6.fr (moderated list:COCCINELLE/Semantic Patches (SmPL))
linux-kernel@vger.kernel.org (open list)

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
  2019-07-31 14:21     ` Michal Simek
@ 2019-08-02  4:59       ` Nishka Dasgupta
  2019-08-02  5:12         ` Michal Simek
  0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2019-08-02  4:59 UTC (permalink / raw)
  To: Michal Simek, jassisinghbrar, linux-kernel, linux-arm-kernel

On 31/07/19 7:51 PM, Michal Simek wrote:
> On 31. 07. 19 15:06, Nishka Dasgupta wrote:
>> On 31/07/19 2:01 PM, Michal Simek wrote:
>>> On 09. 07. 19 19:28, Nishka Dasgupta wrote:
>>>> Each iteration of for_each_available_child_of_node puts the previous
>>>> node, but in the case of a goto from the middle of the loop, there is
>>>> no put, thus causing a memory leak. Hence add an of_node_put before the
>>>> goto.
>>>> Issue found with Coccinelle.
>>>>
>>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>>>> ---
>>>>    drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> index 86887c9a349a..bd80d4c10ec2 100644
>>>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct
>>>> platform_device *pdev)
>>>>            if (ret) {
>>>>                dev_err(dev, "failed to probe subdev.\n");
>>>>                ret = -EINVAL;
>>>> +            of_node_put(nc);
>>>>                goto free_mbox_dev;
>>>>            }
>>>>            mbox++;
>>>>
>>>
>>> Patch is good but when you are saying that this was found by Coccinelle
>>> then it should be added as script to kernel to detect it.
>>
>> This particular patch was suggested by a script I did not write myself;
>> someone else wrote it and sent it to me. How should I proceed in this case?
> 
> You can ask him to submit it to kernel.
> Or you can take it, keep his authorship and send it to:

I have asked her to submit this script, thank you. Will I need to 
resubmit this patch, however?

Regards,
Nishka

> ./scripts/get_maintainer.pl -f scripts/coccinelle/
> Julia Lawall <Julia.Lawall@lip6.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Gilles Muller <Gilles.Muller@lip6.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Nicolas Palix <nicolas.palix@imag.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Michal Marek <michal.lkml@markovi.net> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> cocci@systeme.lip6.fr (moderated list:COCCINELLE/Semantic Patches (SmPL))
> linux-kernel@vger.kernel.org (open list)
> 
> Thanks,
> Michal
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
  2019-08-02  4:59       ` Nishka Dasgupta
@ 2019-08-02  5:12         ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2019-08-02  5:12 UTC (permalink / raw)
  To: Nishka Dasgupta, Michal Simek, jassisinghbrar, linux-kernel,
	linux-arm-kernel

On 02. 08. 19 6:59, Nishka Dasgupta wrote:
> On 31/07/19 7:51 PM, Michal Simek wrote:
>> On 31. 07. 19 15:06, Nishka Dasgupta wrote:
>>> On 31/07/19 2:01 PM, Michal Simek wrote:
>>>> On 09. 07. 19 19:28, Nishka Dasgupta wrote:
>>>>> Each iteration of for_each_available_child_of_node puts the previous
>>>>> node, but in the case of a goto from the middle of the loop, there is
>>>>> no put, thus causing a memory leak. Hence add an of_node_put before
>>>>> the
>>>>> goto.
>>>>> Issue found with Coccinelle.
>>>>>
>>>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>>>>> ---
>>>>>    drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>>> b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>>> index 86887c9a349a..bd80d4c10ec2 100644
>>>>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>>> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct
>>>>> platform_device *pdev)
>>>>>            if (ret) {
>>>>>                dev_err(dev, "failed to probe subdev.\n");
>>>>>                ret = -EINVAL;
>>>>> +            of_node_put(nc);
>>>>>                goto free_mbox_dev;
>>>>>            }
>>>>>            mbox++;
>>>>>
>>>>
>>>> Patch is good but when you are saying that this was found by Coccinelle
>>>> then it should be added as script to kernel to detect it.
>>>
>>> This particular patch was suggested by a script I did not write myself;
>>> someone else wrote it and sent it to me. How should I proceed in this
>>> case?
>>
>> You can ask him to submit it to kernel.
>> Or you can take it, keep his authorship and send it to:
> 
> I have asked her to submit this script, thank you. Will I need to
> resubmit this patch, however?

I will let Jassi to decide.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-02  5:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 17:28 [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto Nishka Dasgupta
2019-07-31  8:31 ` Michal Simek
2019-07-31 13:06   ` Nishka Dasgupta
2019-07-31 14:21     ` Michal Simek
2019-08-02  4:59       ` Nishka Dasgupta
2019-08-02  5:12         ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).