From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbcIHBqm (ORCPT ); Wed, 7 Sep 2016 21:46:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34087 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbcIHBqd (ORCPT ); Wed, 7 Sep 2016 21:46:33 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 07 Sep 2016 18:46:32 -0700 From: spjoshi@codeaurora.org To: Bjorn Andersson Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-remoteproc-owner@vger.kernel.org Subject: Re: [PATCH v2 01/17] rpmsg: Enable matching devices with drivers based on DT In-Reply-To: <1472768889-3906-2-git-send-email-bjorn.andersson@linaro.org> References: <1472768889-3906-1-git-send-email-bjorn.andersson@linaro.org> <1472768889-3906-2-git-send-email-bjorn.andersson@linaro.org> Message-ID: User-Agent: Roundcube Webmail/1.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-09-01 15:27, Bjorn Andersson wrote: > Make it possible to match rpmsg devices based on device tree node, in > addition to the id table. In some of these cases the rpmsg driver would > not have a id_table, so make this optional. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - None > > drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c > b/drivers/rpmsg/virtio_rpmsg_bus.c > index 4a4374cc6a59..495fa0a282d3 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > > /** > * struct virtproc_info - virtual remote processor state > @@ -175,11 +176,12 @@ static int rpmsg_dev_match(struct device *dev, > struct device_driver *drv) > const struct rpmsg_device_id *ids = rpdrv->id_table; > unsigned int i; > > - for (i = 0; ids[i].name[0]; i++) > - if (rpmsg_id_match(rpdev, &ids[i])) > - return 1; > + if (ids) > + for (i = 0; ids[i].name[0]; i++) > + if (rpmsg_id_match(rpdev, &ids[i])) > + return 1; > > - return 0; > + return of_driver_match_device(dev, drv); Do we care falling back to acpi_driver_match_device if of_driver_match_device fails (something similar to what platform_match does)? > } > > static int rpmsg_uevent(struct device *dev, struct kobj_uevent_env > *env) Sarang -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project