From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Helen Koike <helen.koike@collabora.com>,
linux-rockchip@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
jeffy.chen@rock-chips.com, zyc@rock-chips.com,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
robh+dt@kernel.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, linux-media@vger.kernel.org,
jacob-chen@iotwrt.com, zhengsq@rock-chips.com
Subject: Re: [PATCH v11 00/11] Rockchip ISP Driver
Date: Tue, 19 Nov 2019 09:30:57 +0100 [thread overview]
Message-ID: <eafffc6f-061e-65ab-079b-b2bd613d61cb@xs4all.nl> (raw)
In-Reply-To: <7fd4bf99fd6316da8acaf0a27b6845bedbf4b25f.camel@collabora.com>
On 11/18/19 7:52 PM, Ezequiel Garcia wrote:
> Hi Hans,
>
> Thanks for taking care of this.
>
> On Thu, 2019-11-14 at 09:42 +0100, Hans Verkuil wrote:
>> On 11/14/19 6:12 AM, Helen Koike wrote:
>>> Hello,
>>>
>>> This series adds the Rockchip Image Signal Processing Unit v1 driver to
>>> staging.
>>>
>>> The main reason to be in staging is that people are already using it from the
>>> mailing list (including libcamera), and having it in mainline makes the workflow
>>> easier. Also, it is easier for other people to contribute back (with code
>>> or testing the driver).
>>>
>>> We plan to actively work on this driver to get it our of staging.
>>>
>>> This patchset is also available at:
>>> https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/v11
>>>
>>> Libcamera patched to work with this version:
>>> https://gitlab.collabora.com/koike/libcamera
>>> (also sent to the mailing list)
>>>
>>> The major difference in v11 are:
>>> - Fixed compiling warnings found with W=1
>>> - Fixed checkpatch errors
>>> - Add clock-names values in dt-bindings
>>
>> Looking at checkpatch I see a few remaining issues that I believe should be
>> fixed before merging this:
>>
>> CHECK: spinlock_t definition without comment
>> #575: FILE: drivers/staging/media/rkisp1/isp_stats.h:43:
>> + spinlock_t irq_lock;
>>
>> CHECK: struct mutex definition without comment
>> #581: FILE: drivers/staging/media/rkisp1/isp_stats.h:49:
>> + struct mutex wq_lock;
>>
>> CHECK: spinlock_t definition without comment
>> #1648: FILE: drivers/staging/media/rkisp1/isp_params.h:25:
>> + spinlock_t config_lock;
>>
>> CHECK: spinlock_t definition without comment
>> #2058: FILE: drivers/staging/media/rkisp1/capture.h:145:
>> + spinlock_t vbq_lock;
>>
>
> I'd rather merge this as-is, adding a TODO entry stating
> we need to revisit locking specifically, because I'd like
> to take a close look at these spinlocks/mutex,
> instead of just addding comments for then.
Fair enough! Just as long as it is mentioned somewhere.
>
>> Once this is done together with the Jacob Chen email clarification
>> it is ready to be merged for v5.6.
>>
>
> I'll find out more about this.
Thanks!
Remember that we are in the code freeze until v5.5-rc1 is released,
so you have time to make more adjustments if you want to.
Regards,
Hans
>
>> It passes all the sparse/smatch tests, so that's very good.
>>
>
> Great!
>
> Thanks,
> Ezequiel
>
prev parent reply other threads:[~2019-11-19 8:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 5:12 [PATCH v11 00/11] Rockchip ISP Driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 01/11] media: staging: phy-rockchip-dphy: add Rockchip MIPI Synopsys DPHY driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1 meta buffer format Helen Koike
2019-11-14 8:21 ` Hans Verkuil
2019-11-14 8:47 ` Tomasz Figa
2019-11-14 10:58 ` Helen Koike
2019-11-19 10:16 ` Jacob Chen
2019-11-19 12:55 ` Ezequiel Garcia
2019-11-19 13:03 ` Tomasz Figa
2019-11-14 5:12 ` [PATCH v11 03/11] media: staging: rkisp1: add user space ABI definitions Helen Koike
2019-11-14 5:12 ` [PATCH v11 04/11] media: staging: rkisp1: add Rockchip ISP1 subdev driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 05/11] media: staging: rkisp1: add ISP1 statistics driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 06/11] media: staging: rkisp1: add ISP1 params driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 07/11] media: staging: rkisp1: add capture device driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 08/11] media: staging: rkisp1: add rockchip isp1 core driver Helen Koike
2019-11-14 5:12 ` [PATCH v11 09/11] media: staging: dt-bindings: Document the Rockchip ISP1 bindings Helen Koike
2019-11-14 5:12 ` [PATCH v11 10/11] media: staging: dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Helen Koike
2019-11-14 5:12 ` [PATCH v11 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
2019-11-14 5:17 ` [PATCH v11 00/11] Rockchip ISP Driver Greg KH
2019-11-14 7:22 ` Hans Verkuil
2019-11-14 8:42 ` Hans Verkuil
2019-11-18 18:52 ` Ezequiel Garcia
2019-11-19 8:30 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eafffc6f-061e-65ab-079b-b2bd613d61cb@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=jacob-chen@iotwrt.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).